Bug/stopwatch lap time overlap (new approach) #365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en lap time is longer than minutes e.g. 00:00.00 (#1) Co-authored-by: AshBash <ash@tuxbet.com>
Adjusted layout width to wrap content so as the number of digits increases, so does the width of the box. Set the minWidth to the lap size dimension (for initial width) changed the layoutmethod from Packed to Spread Inside to prevent misalignment when number of digits in different laps is different. e.g when some laps are seconds long and others greater than 1 minute. Added margins at the end of the Lap Order and Lap Time Size boxes ensuring that when times are greater than 1 minute the values aren't too close together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No AI was used for any code generation or filling in of this form.
Type of change(s)
What changed and why
Based on the feedback from @naveensingh in this Pull Request, changing the width dimension of each lap time component was "not the correct fix" so I implemented a more dynamic layout and added margins between the lap order, lap_lap_time and lap_total_time components.
Updated the layout of the stopwatch lap times components including:
lap_order, lap_lap_time and lap_total time
Adjusted layout width to not be fixed dimension (which was too small previously), the width now wraps the content. The min width is set to the previous lap_time_size dimension which provides the initial width for when the lap time is less than 1 minute.
Added margins between the boxes to ensure they do not go too close together when each lap time is greater than 1 minute.
Updated the horizontal layout chain style of the lap order component to ensure that columns are aligned when there are some laps with <1 minute times and other laps of > 1 minute.
Tests performed
Tested the previous version and reproduced the bug when changing font size to largest on Samsung Galaxy S24+
Made the changes, compiled the debug build, deployed and tested via wireless ADB.
Tested and verified the issue was fixed when font size is largest and the layout looks good.
Before & after preview
Before:
After:
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).