fix: prevent app close on sleep timer reset#382
fix: prevent app close on sleep timer reset#382IDS-YN wants to merge 3 commits intoFossifyOrg:mainfrom
Conversation
Second file edit for the fixe of this bug: FossifyOrg#345 Changed the logic for PlaybackService.toggleSleepTimer() to be sure the sleeptimer stops when the timer hits 0 and that the timer starts/keeps going at 0 of above so when there's already a sleeptimer set it wont cause a problem. New val sleepTimerCurrent corresponds to current value in the timer, hope it stays in style with the writing code. Once again sorry for making the pull in two requests instead of one.
naveensingh
left a comment
There was a problem hiding this comment.
Once again sorry for making the pull in two requests instead of one.
You can make changes to this PR's branch directly using GitHub. Just redo the changes from your first PR https://github.com/FossifyOrg/Music-Player/pull/381/changes to the file located here: MainActivity.kt (click to edit)
Thanks.
Following the comment, remaking the edit here
Hi! It has been done :) Thanks for the instructions, if there's any problem with my contribution (it should normally be all good as it has been tested on Android Studio) let me know! Have a nice day! |
Second file edit for the fixe of this bug: #345
Changed the logic for PlaybackService.toggleSleepTimer() to be sure the sleeptimer stops when the timer hits 0 and that the timer starts/keeps going at 0 of above so when there's already a sleeptimer set it wont cause a problem. New val sleepTimerCurrent corresponds to current value in the timer, hope it stays in style with the writing code.
Once again sorry for making the pull in two requests instead of one.
Type of change(s)
What changed and why
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).