fix: Prevent broken/strange checklist reordering #282
Merged
+21
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an extra note upon the below: This is my first encounter with Kotlin, and my Android experience is minimal (mostly from a decade ago) so sorry if any of this is poorly done!
Type of change(s)
What changed and why
Updates the checklist reorder moves to filter and just consider those which are visually re-orderable within the UI, since odd behaviour could occur when the fundamental task data had checked items between unchecked items while the "Move checked items to the bottom" setting was enabled. This could occur from toggling the "Move checked items to the bottom" option, or by attempting to move a task item into/below the "Checked items" list.
This also adds a check when moving an item down, since the move handling would consider the "Checked items" as an element when emitting position changes.
Tests performed
Closes the following issue(s)
Checklist
CHANGELOG.md(if applicable).