Skip to content

Commit f89f6f1

Browse files
JohnAZoidbergquinchou77
authored andcommitted
fwk: pwr button can always be updated
The threshold is really low, so I don't expect it to bounce back and forth. BUG=sometimes the kb backlight doesn't turn on even if I cover ALS with my finger TEST=See bug, press FN+space until auto kb brightness and cover ALS with finger. Make sure it can always turn on/off BRANCH=fwk-main Signed-off-by: Daniel Schaefer <dhs@frame.work> (cherry picked from commit eb85ad0)
1 parent 2346af7 commit f89f6f1

File tree

1 file changed

+15
-17
lines changed
  • zephyr/program/framework/src

1 file changed

+15
-17
lines changed

zephyr/program/framework/src/led.c

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,23 @@ void auto_als_led_brightness(void)
227227
int led_brightness;
228228
#ifdef CONFIG_PLATFORM_EC_KEYBOARD
229229
int kb_brightness;
230+
231+
if (kbbl_auto_dim_is_enable()) {
232+
last_kbbl_led_brightness = kblight_get();
233+
234+
if (als_lux > 5)
235+
kb_brightness = KEYBOARD_BL_BRIGHTNESS_OFF;
236+
else
237+
kb_brightness = KEYBOARD_BL_BRIGHTNESS_ULT_LOW;
238+
239+
if (last_kbbl_led_brightness != kb_brightness) {
240+
last_kbbl_led_brightness = kb_brightness;
241+
kblight_set(kb_brightness);
242+
}
243+
}
230244
#endif
231245

232-
/* Only change brightness if lux has significantly changed */
246+
/* Only change power button brightness if lux has significantly changed */
233247
/* Otherwise if it's around a threshold it might flip back and forth */
234248
if (prev_als_lux != 0 && (ABS(als_lux - prev_als_lux) <= 15))
235249
return;
@@ -254,22 +268,6 @@ void auto_als_led_brightness(void)
254268
update_pwr_led_level();
255269
}
256270
}
257-
258-
#ifdef CONFIG_PLATFORM_EC_KEYBOARD
259-
if (kbbl_auto_dim_is_enable()) {
260-
last_kbbl_led_brightness = kblight_get();
261-
262-
if (als_lux > 5)
263-
kb_brightness = KEYBOARD_BL_BRIGHTNESS_OFF;
264-
else
265-
kb_brightness = KEYBOARD_BL_BRIGHTNESS_ULT_LOW;
266-
267-
if (last_kbbl_led_brightness != kb_brightness) {
268-
last_kbbl_led_brightness = kb_brightness;
269-
kblight_set(kb_brightness);
270-
}
271-
}
272-
#endif
273271
}
274272

275273
/*

0 commit comments

Comments
 (0)