Conversation
|
Successfully created backport PR for |
There was a problem hiding this comment.
Pull request overview
Updates the Addon Manager’s cache base directory to a versioned, unique subfolder to prevent conflicts with caches created by older cache formats.
Changes:
- Version the cache directory by appending a unique subdirectory (
AddonManager2026-1) undergetUserCachePath().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Anytime the cache format changes, increment this version number so we don't | ||
| # interfere with old versions. | ||
| self.cache_dir = os.path.join(getUserCachePath(), "AddonManager2026-1") |
There was a problem hiding this comment.
The cache "version number" is currently embedded directly in the directory name ("AddonManager2026-1"), which makes it easy to forget to update consistently and also makes the intent less clear than an explicit cache-format version constant. Consider introducing a dedicated constant (e.g., CACHE_FORMAT_VERSION) and composing the directory name from it so future cache format bumps are a one-line change and the naming scheme stays consistent.
Fix problems caused by interactions between the current cache version and old formats of the cache.