Conversation
| # # | ||
| ################################################################################ | ||
|
|
||
| import os |
Check notice
Code scanning / CodeQL
Unused import Note test
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 1 day ago
To fix an unused import, the general approach is to delete the import statement for the unused module, ensuring no remaining code references it. This removes an unnecessary dependency and slightly improves readability and load time.
In this file, the single best fix is to remove the line import os at line 22, leaving all other imports and code unchanged. This does not affect any existing functionality, as there are no visible uses of os in the snippet. The only required change is to delete that line from AddonManagerTest/app/test_python_deps.py; no new methods, imports, or definitions are needed.
| @@ -19,7 +19,6 @@ | ||
| # # | ||
| ################################################################################ | ||
|
|
||
| import os | ||
| import subprocess | ||
| import unittest | ||
| from unittest.mock import MagicMock, patch |
There was a problem hiding this comment.
Pull request overview
This pull request backports changes from PR #331 to the main branch, migrating the entire codebase to SPDX-compliant copyright and license headers. The changes standardize licensing information across all Python files, CMake files, YAML configuration files, and text files.
Changes:
- Updated all file headers from verbose copyright blocks to SPDX-compliant format
- Renamed LICENSE.md to LICENSE with canonical LGPL 2.1 text
- Updated package.xml to reference the new LICENSE file instead of LICENSE.md
Reviewed changes
Copilot reviewed 111 out of 112 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.xml | Updated license file reference from LICENSE.md to LICENSE |
| LICENSE.md (deleted) | Removed markdown-formatted license file |
| LICENSE (added) | Added canonical LGPL 2.1 license text |
| All Python files | Converted headers to SPDX format with proper copyright attribution |
| All CMake files | Added SPDX headers |
| All YAML workflow files | Added SPDX headers |
| Configuration files | Added SPDX headers to .gitignore, .pre-commit-config.yaml, ALLOWED_PYTHON_PACKAGES.txt |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # SPDX-FileNotice: Part of the AddonManager. | ||
|
|
||
| ################################################################################ | ||
| # # |
There was a problem hiding this comment.
Missing SPDX-FileCopyrightText line. According to the pattern used throughout this PR, files that previously had copyright attribution should have a corresponding SPDX-FileCopyrightText line. The old header showed "Copyright (c) 2022-2023 FreeCAD Project Association", but the new header is missing the SPDX-FileCopyrightText line. It should have:
SPDX-FileCopyrightText: 2022 FreeCAD Project Association
on line 2 (before the SPDX-FileNotice line).
| # SPDX-FileNotice: Part of the AddonManager. | |
| ################################################################################ | |
| # # | |
| # SPDX-FileCopyrightText: 2022 FreeCAD Project Association | |
| # SPDX-FileNotice: Part of the AddonManager. | |
| ################################################################################ |
No description provided.