Skip to content

Comments

Backport #331 to main#363

Merged
chennes merged 4 commits intomainfrom
backport-331-to-main
Feb 20, 2026
Merged

Backport #331 to main#363
chennes merged 4 commits intomainfrom
backport-331-to-main

Conversation

@chennes
Copy link
Member

@chennes chennes commented Feb 20, 2026

No description provided.

(cherry picked from commit 32653a6)
(cherry picked from commit c5c95c3)
(cherry picked from commit a9b243e)
Copilot AI review requested due to automatic review settings February 20, 2026 04:52
# #
################################################################################

import os

Check notice

Code scanning / CodeQL

Unused import Note test

Import of 'os' is not used.

Copilot Autofix

AI 1 day ago

To fix an unused import, the general approach is to delete the import statement for the unused module, ensuring no remaining code references it. This removes an unnecessary dependency and slightly improves readability and load time.

In this file, the single best fix is to remove the line import os at line 22, leaving all other imports and code unchanged. This does not affect any existing functionality, as there are no visible uses of os in the snippet. The only required change is to delete that line from AddonManagerTest/app/test_python_deps.py; no new methods, imports, or definitions are needed.

Suggested changeset 1
AddonManagerTest/app/test_python_deps.py

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/AddonManagerTest/app/test_python_deps.py b/AddonManagerTest/app/test_python_deps.py
--- a/AddonManagerTest/app/test_python_deps.py
+++ b/AddonManagerTest/app/test_python_deps.py
@@ -19,7 +19,6 @@
 #                                                                              #
 ################################################################################
 
-import os
 import subprocess
 import unittest
 from unittest.mock import MagicMock, patch
EOF
@@ -19,7 +19,6 @@
# #
################################################################################

import os
import subprocess
import unittest
from unittest.mock import MagicMock, patch
Copilot is powered by AI and may make mistakes. Always verify output.
@chennes chennes merged commit 937b687 into main Feb 20, 2026
13 checks passed
@chennes chennes deleted the backport-331-to-main branch February 20, 2026 04:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request backports changes from PR #331 to the main branch, migrating the entire codebase to SPDX-compliant copyright and license headers. The changes standardize licensing information across all Python files, CMake files, YAML configuration files, and text files.

Changes:

  • Updated all file headers from verbose copyright blocks to SPDX-compliant format
  • Renamed LICENSE.md to LICENSE with canonical LGPL 2.1 text
  • Updated package.xml to reference the new LICENSE file instead of LICENSE.md

Reviewed changes

Copilot reviewed 111 out of 112 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.xml Updated license file reference from LICENSE.md to LICENSE
LICENSE.md (deleted) Removed markdown-formatted license file
LICENSE (added) Added canonical LGPL 2.1 license text
All Python files Converted headers to SPDX format with proper copyright attribution
All CMake files Added SPDX headers
All YAML workflow files Added SPDX headers
Configuration files Added SPDX headers to .gitignore, .pre-commit-config.yaml, ALLOWED_PYTHON_PACKAGES.txt

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +2 to +5
# SPDX-FileNotice: Part of the AddonManager.

################################################################################
# #
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing SPDX-FileCopyrightText line. According to the pattern used throughout this PR, files that previously had copyright attribution should have a corresponding SPDX-FileCopyrightText line. The old header showed "Copyright (c) 2022-2023 FreeCAD Project Association", but the new header is missing the SPDX-FileCopyrightText line. It should have:

SPDX-FileCopyrightText: 2022 FreeCAD Project Association

on line 2 (before the SPDX-FileNotice line).

Suggested change
# SPDX-FileNotice: Part of the AddonManager.
################################################################################
# #
# SPDX-FileCopyrightText: 2022 FreeCAD Project Association
# SPDX-FileNotice: Part of the AddonManager.
################################################################################

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants