[deprecation] [warning] Remove using null as an array offset is deprecated and will trigger a deprecation notice in PHP 8.5. #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bahiirwa
force-pushed
the
feature/laurence/fix-php-85-null-array-message
branch
from
f35d82e to
f3ec5b4
Compare
DanieleFreemius
approved these changes
Jan 21, 2026
Contributor
DanieleFreemius
left a comment
DanieleFreemius
left a comment
There was a problem hiding this comment.
LGTM
Passing empty strings to add_query_arg() is acceptable here.
While using add_query_arg( [], admin_url() ) would be semantically cleaner, the current change preserves existing behavior with a minimal diff and avoids the PHP 8.5 deprecation without introducing any functional or stylistic refactors.
Approved.
DanieleAlessandra
approved these changes
Jan 21, 2026
Collaborator
DanieleAlessandra
left a comment
DanieleAlessandra
left a comment
There was a problem hiding this comment.
LGTM
Passing empty strings to add_query_arg() is acceptable here.
While using add_query_arg( [], admin_url() ) would be semantically cleaner, the current change preserves existing behavior with a minimal diff and avoids the PHP 8.5 deprecation without introducing any functional or stylistic refactors.
Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REASON:
In PHP 8.5, using null as an array offset is deprecated and will trigger a deprecation notice. Previously, null was silently coerced to an empty string ("") when used as an array key, but this implicit behavior is being phased out to improve consistency with other parts of the language.
Solution
Changing the null to empty strings fixed the issue, as the WordPress function expects strings to be used as URI/URLs. https://developer.wordpress.org/reference/functions/add_query_arg/