Milestone 4 & 5: Chart Component + 53-Control Feature Audit#341
Merged
csharpfritz merged 38 commits intoFritzAndFriends:devfrom Feb 23, 2026
Merged
Milestone 4 & 5: Chart Component + 53-Control Feature Audit#341csharpfritz merged 38 commits intoFritzAndFriends:devfrom
csharpfritz merged 38 commits intoFritzAndFriends:devfrom
Conversation
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
Co-authored-by: csharpfritz <78577+csharpfritz@users.noreply.github.com>
…ends#333) - Create CalendarSelectionMode enum (None, Day, DayWeek, DayWeekMonth) - Refactor Calendar.SelectionMode from string to CalendarSelectionMode enum - Remove .GetAwaiter().GetResult() blocking call in CreateDayRenderArgs - Add Caption, CaptionAlign, UseAccessibleHeader properties - Update tests and samples to use enum values
- Calendar: date selection, selection modes, styling, day/title formats, events - FileUpload: basic upload, file type filtering, multiple files, disabled, styled - ImageMap: navigate/postback/mixed hot spot modes, rectangle/circle/polygon shapes - Updated NavMenu and ComponentList with links to all three new components
…ents into dev # Conflicts: # docs/EditorControls/FileUpload.md
…Friends#338 merge The FileUpload PR (FritzAndFriends#338) inadvertently reverted Sprint 1 gate review entries from agent histories (beast, cyclops, forge, jubilee, rogue) and downgraded the FileUpload InputFile decision in decisions.md. Restored from commit f85aa42 (docs(ai-team): Sprint 1 gate review results).
Creates .agent.md files for all 6 team agents (Beast, Cyclops, Forge, Jubilee, Rogue, Scribe) so they appear in GitHub Copilot's agent picker. Content sourced from existing .ai-team/agents/*/charter.md files.
Squad is the single Copilot agent that delegates to the specialized agents defined in .ai-team/agents/. Individual agent files were incorrectly created the correct pattern is one coordinator agent (squad.agent.md) that routes work to Forge, Cyclops, Beast, Jubilee, Rogue, and Scribe based on task type.
Session: 2026-02-10-sprint2-complete Requested by: Jeffrey T. Fritz Changes: - Logged Sprint 2 session (4 components shipped with docs, samples, tests) - Merged Sprint 2 design review decision from inbox - Removed duplicate FileUpload InputFile decision from inbox (already consolidated) - Appended Sprint 2 completion decision to decisions.md - Propagated cross-agent updates to all 5 agent histories
…ents into dev # Conflicts: # docs/UtilityFeatures/PageService.md # samples/AfterBlazorServerSide/Components/Pages/ControlSamples/Calendar/Index.razor
Session: 2026-02-11-sprint3-planning Requested by: Jeffrey T. Fritz Changes: - Logged session to .ai-team/log/2026-02-11-sprint3-planning.md - Merged 3 decisions from inbox into decisions.md - Updated status.md to reflect 48/53 components complete - Sprint 3 scope: DetailsView + PasswordRecovery - Propagated cross-agent updates to all agent history files
Session: 2026-02-12-sprint3-execution Requested by: Jeffrey T. Fritz Changes: - Logged Sprint 3 execution session - Merged 7 decisions from inbox into decisions.md - Sprint 3 gate review: DetailsView + PasswordRecovery APPROVED - Propagated cross-agent updates to Beast, Colossus, Cyclops, Rogue, Jubilee - status.md updated to 50/53 (94%)
Session: 2026-02-12-milestone4-planning Requested by: Jeffrey T. Fritz Changes: - Logged session to .ai-team/log/2026-02-12-milestone4-planning.md - Merged decisions from inbox (Chart.js evaluation, milestone plan, milestones directive) - Propagated milestone 4 updates to 5 agent history files
Session: 2026-02-12-milestone4-planning Requested by: Scribe (automatic) Changes: - Summarized Forge history.md (exceeded ~12KB threshold) - Preserved all team updates and key patterns
- Add Chart, ChartSeries, ChartArea, ChartLegend, ChartTitle components - Add JS interop infrastructure (chart-interop.js, ChartJsInterop.cs) - Add ChartConfigBuilder for component state -> Chart.js JSON config - Add SeriesChartType, ChartPalette, Docking, ChartDashStyle enums - Add DataPoint and Axis POCOs - Add 140 bUnit tests for Chart components (866 total, all passing) - Add 8 Chart sample pages (Column, Line, Bar, Pie, Area, Doughnut, Scatter, StackedColumn) - Add 19 Chart integration tests - Add Chart documentation and update mkdocs.yml, README, status.md - Fix integration test console error filter for ASP.NET structured logs - Fix integration test filter for external resource loading errors - Fix duplicate FileUpload route (delete old Pages/ControlSamples/FileUpload/Default.razor) - Fix ChangePassword and CreateUserWizard test assertions for EditForm rendering - All tests green: 866 bUnit + 124 integration tests
Session: 2026-02-14-chart-implementation Requested by: Jeffrey T. Fritz Changes: - Logged session: Chart data binding and Playwright tests shipped - Merged 7 decision files from inbox (Chart visual tests, data binding, implementation, samples) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Fix ChartSeries.ToConfig() to support Items/XValueMember/YValueMembers data binding - Add 12 data binding unit tests (152 Chart tests total) - Create 4 new sample pages: DataBinding, MultiSeries, Styling, ChartAreas - Add 38 Playwright integration tests for Chart appearance verification - All 143 integration tests and 152 Chart unit tests pass Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- ChartAreas, DataBinding, MultiSeries, Styling routes now tested - All 42 Chart integration tests pass - Completes Forge's gate review requirements Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…randing - Upgraded Bootstrap 4.3.1 to 5.3.3 - Fixed pl-4 -> ps-4 utility class in NavMenu.razor - Created ComponentCatalog.cs with 36 components across 6 categories - Added GetByCategory, GetByRoute, Search helper methods - Created logo.svg with migration concept (Web Forms -> Blazor) - Added brand-colors.css with custom properties - Updated App.razor with favicon and brand stylesheet Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Redesigned MainLayout.razor with modern Bootstrap 5 navbar - Fixed-top navbar with logo, search placeholder, external links - Collapsible sidebar with hamburger menu on mobile - Footer with GitHub link and MIT License - data-bs-theme attribute for future dark mode support - Refactored NavMenu.razor to use ComponentCatalog - Data-driven rendering with collapsible category sections - Tooltips on component links with descriptions - Current page highlighting and auto-expand categories - Badge showing component count per category - Created SamplePageTemplate.razor with card-based layout - Title, Description, DemoContent, CodeExample sections - Consistent styling using brand colors - Fixed Menu_Renders_WithItems test (ul/li vs table) All 147 integration tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Implemented client-side search with Fuse.js fuzzy matching - SearchBox.razor with debounced search (200ms) - Keyboard navigation (up/down/enter/escape) - Match highlighting in results - Category badges and truncated descriptions - Redesigned homepage with hero section and card-based catalog - Gradient hero with CTA buttons (Get Started, View on GitHub) - 6 category cards with component counts and links - Responsive grid (3/2/1 columns for desktop/tablet/mobile) - Fixed sidebar layout issues - Removed redundant header text - Categories expanded by default on desktop - Mobile nav collapse on link click All 147 integration tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Added 4 screenshots showcasing the sample site: - Homepage with component catalog - GridView with interactive data binding - Chart component with Chart.js - Fuzzy search feature Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixed route mismatches between ComponentCatalog and actual page routes: - MasterPage: /ControlSamples/MasterPage -> /control-samples/masterpage - FormView: /ControlSamples/FormView -> /ControlSamples/FormView/Simple - DataList: SimpleFlow subpage -> Flow (matches actual route) - Validation controls: Removed /Validations/ prefix from routes - Login controls: Removed /LoginControls/ prefix from routes - LoginStatus: Removed NotAuthenticated subpage (has separate route) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The global footer in App.razor was spanning full width and appearing behind the fixed-position sidebar. Added inline styles in head to ensure the footer respects sidebar width with responsive handling. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…eenshots - Fix per-segment color assignment for pie/doughnut charts in ChartConfigBuilder - Replace chart.min.js placeholder with real Chart.js v4.4.8 (201KB) - Add Playwright-generated screenshots for all 8 chart types to docs/images/chart/ - Add Chart Type Gallery section to Chart.md documentation - Remove palette limitation warnings (bug is now fixed) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Evaluate 5 Blazor-native approaches to replicate Web Forms Themes and Skins functionality: CSS Custom Properties, CascadingValue ThemeProvider, Generated CSS Isolation, DI-based Configuration, and Hybrid. Recommend CascadingValue ThemeProvider as the primary approach due to full Web Forms fidelity (Theme/StyleSheetTheme semantics, SkinID support, all property types). Document is exploratory per Jeff's request. - Create docs/Migration/ThemesAndSkins.md with full analysis - Add to mkdocs.yml nav under Migration section - Record decision in .ai-team/decisions/inbox/ - Update forge history with learnings Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Session: 2026-02-23-feature-audit Requested by: Jeffrey T. Fritz Changes: - Logged session to .ai-team/log/2026-02-23-feature-audit.md - Merged 8 decisions from inbox into decisions.md - Consolidated overlapping decisions (AccessKey/ToolTip, Chart architecture, DataBoundComponent gap) - Propagated updates to 6 agent history files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…trategy - Created 53 audit documents in planning-docs/ comparing every ASP.NET Web Forms control against its Blazor component implementation - Created planning-docs/SUMMARY.md with aggregate gap analysis (66.3% feature match) - Created docs/Migration/ThemesAndSkins.md with 5 evaluated migration approaches (recommended: CascadingValue ThemeProvider pattern) - Updated mkdocs.yml nav with ThemesAndSkins entry - Key findings: AccessKey/ToolTip universally missing, GridView weakest at 20.7%, DetailsView+PasswordRecovery stranded on unmerged sprint3 branch, 7 base-class fixes would close ~180 gaps across the library Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Brings in sprint3/detailsview-passwordrecovery (FritzAndFriends#340): - DetailsView component with paging, edit mode, command rows - PasswordRecovery component with 3-step flow - DataBinder/ViewState utility samples - Local SVG placeholder images replacing external URLs - bUnit and Playwright integration tests Conflict resolution: - DeferredControls.md: Kept Chart as Partially Implemented (HEAD) with dev's richer Substitution/Xml documentation - ControlSampleTests.cs: Combined Chart tests (HEAD) + Utility tests (dev), kept comprehensive error filtering - InteractiveComponentTests.cs: Took dev's thorough field-level assertions + all new DetailsView/PasswordRecovery tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Integrates remote work: Phase 1-3 UI overhaul (Bootstrap 5, ComponentCatalog, sidebar), chart data binding samples, and Playwright integration tests for new sample pages. Conflict: NavMenu.razor took remote's ComponentCatalog-driven dynamic nav (UI overhaul) over local's static TreeNode list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1328
to
+1335
| if (yValue != null) | ||
| { | ||
| point.YValues = new[] { Convert.ToDouble(yValue) }; | ||
| } | ||
| else | ||
| { | ||
| point.YValues = Array.Empty<double>(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity
Comment on lines
+101
to
+114
| foreach (var s in seriesList) | ||
| { | ||
| if (s.Points != null && s.Points.Count > 0) | ||
| { | ||
| foreach (var p in s.Points) | ||
| { | ||
| if (!string.IsNullOrEmpty(p.Label)) | ||
| labels.Add(p.Label); | ||
| else if (p.XValue != null) | ||
| labels.Add(p.XValue); | ||
| } | ||
| break; | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where
Comment on lines
+135
to
+148
| if (s.ChartType == SeriesChartType.Point) | ||
| { | ||
| dataset["data"] = s.Points.Select(p => new Dictionary<string, object> | ||
| { | ||
| ["x"] = p.XValue ?? 0, | ||
| ["y"] = p.YValues?.Length > 0 ? p.YValues[0] : 0 | ||
| }).ToList(); | ||
| } | ||
| else | ||
| { | ||
| dataset["data"] = s.Points | ||
| .Select(p => p.YValues?.Length > 0 ? p.YValues[0] : 0.0) | ||
| .ToList(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity
| if (area.AxisX != null) | ||
| { | ||
| var xAxis = BuildAxisConfig(area.AxisX); | ||
| if (scales.ContainsKey("x")) |
Check notice
Code scanning / CodeQL
Inefficient use of ContainsKey
| if (area.AxisY != null) | ||
| { | ||
| var yAxis = BuildAxisConfig(area.AxisY); | ||
| if (scales.ContainsKey("y")) |
Check notice
Code scanning / CodeQL
Inefficient use of ContainsKey
Comment on lines
+113
to
+121
| if (Items != null && !string.IsNullOrEmpty(YValueMembers)) | ||
| { | ||
| config.Points = ExtractDataPointsFromItems(); | ||
| } | ||
| else | ||
| { | ||
| // Fall back to manually-specified Points | ||
| config.Points = Points; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity
Comment on lines
+233
to
+236
| catch | ||
| { | ||
| return false; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause
Comment on lines
+1328
to
+1335
| if (yValue != null) | ||
| { | ||
| point.YValues = new[] { Convert.ToDouble(yValue) }; | ||
| } | ||
| else | ||
| { | ||
| point.YValues = Array.Empty<double>(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note test
Comment on lines
+101
to
+114
| foreach (var s in seriesList) | ||
| { | ||
| if (s.Points != null && s.Points.Count > 0) | ||
| { | ||
| foreach (var p in s.Points) | ||
| { | ||
| if (!string.IsNullOrEmpty(p.Label)) | ||
| labels.Add(p.Label); | ||
| else if (p.XValue != null) | ||
| labels.Add(p.XValue); | ||
| } | ||
| break; | ||
| } | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Where Note
Comment on lines
+135
to
+148
| if (s.ChartType == SeriesChartType.Point) | ||
| { | ||
| dataset["data"] = s.Points.Select(p => new Dictionary<string, object> | ||
| { | ||
| ["x"] = p.XValue ?? 0, | ||
| ["y"] = p.YValues?.Length > 0 ? p.YValues[0] : 0 | ||
| }).ToList(); | ||
| } | ||
| else | ||
| { | ||
| dataset["data"] = s.Points | ||
| .Select(p => p.YValues?.Length > 0 ? p.YValues[0] : 0.0) | ||
| .ToList(); | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
| if (area.AxisX != null) | ||
| { | ||
| var xAxis = BuildAxisConfig(area.AxisX); | ||
| if (scales.ContainsKey("x")) |
Check notice
Code scanning / CodeQL
Inefficient use of ContainsKey Note
| if (area.AxisY != null) | ||
| { | ||
| var yAxis = BuildAxisConfig(area.AxisY); | ||
| if (scales.ContainsKey("y")) |
Check notice
Code scanning / CodeQL
Inefficient use of ContainsKey Note
Comment on lines
+113
to
+121
| if (Items != null && !string.IsNullOrEmpty(YValueMembers)) | ||
| { | ||
| config.Points = ExtractDataPointsFromItems(); | ||
| } | ||
| else | ||
| { | ||
| // Fall back to manually-specified Points | ||
| config.Points = Points; | ||
| } |
Check notice
Code scanning / CodeQL
Missed ternary opportunity Note
Comment on lines
+233
to
+236
| catch | ||
| { | ||
| return false; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
The UI overhaul added ComponentCatalog-driven NavMenu and SearchBox components to AfterBlazorServerSide. Since AfterBlazorClientSide links Layout files via content references, it needs: - ComponentCatalog.cs linked as a compile item (NavMenu depends on it) - @using AfterBlazorServerSide added to client _Imports.razor - @using AfterBlazorServerSide.Components.Shared moved from MainLayout.razor to server-side _Imports.razor (avoids namespace resolution failure in client project where Shared components are not linked) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone 4: Chart Component + Milestone 5: Feature Comparison Audit
Chart Component (Milestone 4)
New Component
Chart Samples and Documentation
UI Overhaul (Sample App)
53-Control Feature Comparison Audit (Milestone 5)
Audit Documents
Summary Statistics (from planning-docs/SUMMARY.md)
Key Findings
Themes and Skins Strategy
Deferred Controls Update
Test Results
Breaking Changes
None.
Next Steps (Milestone 6)
Use audit documents as work backlog to implement missing/broken features.