Skip to content

Conversation

@novadragonDOTspace
Copy link
Contributor

Please check if the PR fulfills these requirements:

  • The commit message follows our guidelines.
  • For bug fixes and features:
    • You tested the changes.

Related issue (if applicable): #

What kind of change does this PR introduce?
This will include the version number in the Release Artifacts from now on.

It mirrors Release Artifact naming of godot, and aids in at least AUR packaging, because some AUR helpers dont regularly clean their cache regularly enough. Makepkg would then will complain, cause it tries to check the SHA256 of the new release with the old release (aka will try to build with the old release). Including the version number should avoid that collision.

Does this PR introduce a breaking change?
Not inherently for the formatter. Maybe some for outside packagers.

New feature or change

What is the current behavior?
Release Artifacts dont include version number

What is the new behavior?
Release artifacts include version number

Other information

@NathanLovato
Copy link
Contributor

Thanks for the contribution note. For next time, don't worry about filling in the template, the main description is good to me.

Just note that this change will currently break the install script of the Godot add-on, and possibly the vs code extension (not sure, this just needs to be checked, the vscode extension downloads and packages a copy of the formatter) so this also needs a patch before merging.

@novadragonDOTspace novadragonDOTspace marked this pull request as draft November 10, 2025 15:33
@novadragonDOTspace
Copy link
Contributor Author

I have changed the godot plugin, and the vscode/vscodium/osscode plugin is outside of this repo and in @DoHe 's hands, so i'll ping them here

@novadragonDOTspace novadragonDOTspace marked this pull request as ready for review November 10, 2025 15:58
@DoHe
Copy link

DoHe commented Nov 10, 2025

Yes, a change like this would probably break the update script of the VSCode extension, but that's no problem. It only runs as part of the extension's publishing step, so existing users won't be affected and I can just update the script once these changes are live.

@NathanLovato NathanLovato merged commit 3082998 into GDQuest:main Nov 10, 2025
1 check passed
@NathanLovato
Copy link
Contributor

Thanks much for the help! I just removed the print calls. I'll make a new release right away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants