This repository was archived by the owner on Oct 26, 2021. It is now read-only.
Fix client validation in LifecycleRequestComplete #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client is validated by comparing the client handle and request ID received as a part of D-Bus call LifecycleRequestComplete. The reqeust ID is generated by converting the client handle to guint, which is 32 bit unsigned int. The client handle is a pointer which can be of 64 bits in size on 64 bit machine. The existing comparison between client handle and request ID is casting request ID to a pointer type, which can give wrong results when comparting against a 64 bit pointer. This patch fixes it by modifying the comparision to cast the client handle to 32 bit instead. Signed-off-by: Vishal Thanki <vishalthanki@gmail.com>
vthanki
force-pushed
the
lifecycle-consumer-fix
branch
from
ccc7057 to
17f0cdc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client is validated by comparing the client handle and request ID
received as a part of D-Bus call LifecycleRequestComplete. The reqeust
ID is generated by converting the client handle to guint, which is 32
bit unsigned int. The client handle is a pointer which can be of 64 bits
in size on 64 bit machine. The existing comparison between client handle
and request ID is casting request ID to a pointer type, which can give
wrong results when comparting against a 64 bit pointer. This patch fixes
it by modifying the comparision to cast the client handle to 32 bit
instead.
Signed-off-by: Vishal Thanki vishalthanki@gmail.com