Skip to content

Rework regtest runner #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
McSinyx wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Rework regtest runner #92

McSinyx wants to merge 2 commits into from

Conversation

@McSinyx
Copy link
Contributor

@McSinyx McSinyx commented Nov 18, 2024 •
edited
Loading

The C++ script is rewritten in Makefile and shell script for concision.

@McSinyx McSinyx mentioned this pull request Dec 5, 2024
Closed
@McSinyx
Copy link
Contributor Author

McSinyx commented Dec 11, 2024 •
edited
Loading

the entire regtest suite will pass on my system, but can fail on other systems. This should be fixed eventually.

I suppose I should remove ef728c8 from this PR then? Edit: I did.

@McSinyx McSinyx mentioned this pull request Dec 18, 2024
Merged
@McSinyx McSinyx force-pushed the regtest branch 2 times, most recently from 703e5c6 to 79fe7d1 Compare December 19, 2024 06:28
@McSinyx
Copy link
Contributor Author

McSinyx commented Dec 19, 2024 •
edited
Loading

The functional purpose of this patch is, like GH-89, to reliably check signals instead of depending on the shell used by system(3). Moving most of the logic to the Makefile allows caching (7a2210d) and separates test build from test execution.

Distributions would expect make check, while you might want to use make check-debug which tests against e9tool linked against bundled elfutils and Zydis.

@McSinyx McSinyx force-pushed the regtest branch 2 times, most recently from 07b626b to e060163 Compare December 19, 2024 06:40
@McSinyx McSinyx force-pushed the regtest branch 2 times, most recently from b3b85df to ee30dc3 Compare January 13, 2025 09:07
@McSinyx
Copy link
Contributor Author

McSinyx commented Jan 13, 2025

@GJDuck, could you please test this and see if it fails anything on your setup?

@McSinyx
Rework regtest runner
a873023 
The C++ script is rewritten in Makefile and shell script for concision.
@McSinyx
Properly invalidate regtest cached artifacts
f5e03f6
@McSinyx
Copy link
Contributor Author

McSinyx commented Jan 30, 2026

@GJDuck, could you please take a look at this one? The missing make check is the only blocker I have before upstreaming my package to Guix.

@GJDuck
Copy link
Owner

GJDuck commented Jan 31, 2026

This does not work when I try it. The make check prints a bunch of E9Tool output (the regtests I presume), then fails for me.

What is wrong with the original C++ regtest.cpp program? It is specialized to handle the test cases in a nice clean way. Can make check be set up to just call this program?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@McSinyx @GJDuck