Skip to content

Conversation

@beckermr
Copy link
Collaborator

This PR adds a benchmark for the discard operation so that we can test the effect of removing the fori_loop in another PR.

@beckermr beckermr enabled auto-merge (squash) January 27, 2025 17:23
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #132 will degrade performances by 49.07%

Comparing bench-rng (6f15cda) with main (671176c)

Summary

❌ 1 regressions
✅ 20 untouched benchmarks
🆕 2 new benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_benchmark_rng_discard[compile] N/A 236.8 ms N/A
🆕 test_benchmark_rng_discard[run] N/A 6.9 ms N/A
test_benchmark_spergel_init[run] 83.6 µs 164.2 µs -49.07%

@beckermr beckermr merged commit 5db44f1 into main Jan 27, 2025
6 checks passed
@beckermr beckermr deleted the bench-rng branch January 27, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants