Skip to content

feat: add benchmark and test of flux frac for interp images #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
beckermr merged 3 commits into from
Jan 27, 2025
Merged

feat: add benchmark and test of flux frac for interp images #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b92b17
feat: add benchmark and test of flux frac for interp images
beckermr Jan 27, 2025
e4b2668
Merge branch 'main' into blah-blah
beckermr Jan 27, 2025
600cad2
Update tests/jax/test_interpolatedimage_utils.py
beckermr Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/jax/test_benchmarks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,25 @@ def test_benchmark_gaussian_init(benchmark, kind):
print(f"time: {dt:0.4g} ms", end=" ")


def _run_benchmark_interpimage_flux_frac(img):
x, y = img.get_pixel_centers()
cenx = img.center.x
ceny = img.center.y
return jgs.interpolatedimage._flux_frac(img.array, x, y, cenx, ceny)


@pytest.mark.parametrize("kind", ["compile", "run"])
def test_benchmark_interpimage_flux_frac(benchmark, kind):
obj = jgs.Gaussian(half_light_radius=0.9).shear(g1=0.1, g2=0.2)
img = obj.drawImage(nx=55, ny=55, scale=0.2, method="no_pixel")
dt = _run_benchmarks(
benchmark,
kind,
lambda: _run_benchmark_interpimage_flux_frac(img).block_until_ready(),
)
print(f"time: {dt:0.4g} ms", end=" ")


@jax.jit
def _run_benchmark_rng_discard(rng):
rng.discard(1000)
Expand Down
74 changes: 74 additions & 0 deletions tests/jax/test_interpolatedimage_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
from jax_galsim.interpolatedimage import (
_draw_with_interpolant_kval,
_draw_with_interpolant_xval,
_flux_frac,
)


Expand Down Expand Up @@ -354,3 +355,76 @@ def test_interpolatedimage_interpolant_sample(interp):
fdev = np.abs(h - yv) / np.abs(np.sqrt(yv))
np.testing.assert_allclose(fdev[msk], 0, rtol=0, atol=5.0, err_msg=f"{interp}")
np.testing.assert_allclose(fdev[~msk], 0, rtol=0, atol=15.0, err_msg=f"{interp}")


def test_interpolatedimage_flux_frac():
obj = jax_galsim.Gaussian(half_light_radius=0.9).shear(g1=0.1, g2=0.2)
img = obj.drawImage(nx=55, ny=55, scale=0.05, method="no_pixel")
true_val = [
0.02186161,
0.06551123,
0.10894079,
0.15200604,
0.19456641,
0.23648629,
0.27763629,
0.31789470,
0.35714823,
0.39529300,
0.43223542,
0.46789303,
0.50219434,
0.53507960,
0.56650090,
0.59642231,
0.62481892,
0.65167749,
0.67699528,
0.70077991,
0.72304893,
0.74382806,
0.76315117,
0.78105938,
0.79759991,
0.81282544,
0.82679272,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
0.83956224,
]

x, y = img.get_pixel_centers()
cenx = img.center.x
ceny = img.center.y
val = _flux_frac(img.array, x, y, cenx, ceny)
np.testing.assert_allclose(
val,
true_val,
rtol=0,
atol=1e-6,
)
Loading