Skip to content

Conversation

@beckermr
Copy link
Collaborator

This PR removes the fori_loop used to compute the flux fraction for interpolated images.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2025

CodSpeed Performance Report

Merging #134 will degrade performances by 33.9%

Comparing opt-flux-frac (3abd2f0) with main (9b2c0b7)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 22 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_benchmark_interpimage_flux_frac[compile] 282.5 ms 235.4 ms +20.02%
test_benchmark_interpimage_flux_frac[run] 1.8 ms 2.7 ms -33.9%
test_benchmark_spergel_init[run] 165.2 µs 83.4 µs +97.94%

@beckermr beckermr marked this pull request as ready for review January 27, 2025 21:23
@beckermr beckermr merged commit 675f112 into main Jan 28, 2025
6 checks passed
@beckermr beckermr deleted the opt-flux-frac branch January 28, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants