Skip to content

Conversation

@beckermr
Copy link
Collaborator

This PR removes the fori_loop in the fits wcs.

@beckermr beckermr marked this pull request as ready for review January 29, 2025 13:03
@beckermr beckermr marked this pull request as draft January 29, 2025 13:03
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #136 will degrade performances by 71.7%

Comparing fitswcs-no-loop (b5b520d) with main (2f64269)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_benchmark_invert_ab_noraise[compile] 479.1 ms 1,693.1 ms -71.7%
test_benchmark_spergel_init[run] 128.2 µs 84.8 µs +51.21%

@beckermr beckermr marked this pull request as ready for review January 29, 2025 13:49
@beckermr beckermr merged commit a946ce3 into main Jan 29, 2025
6 checks passed
@beckermr beckermr deleted the fitswcs-no-loop branch January 29, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants