Skip to content

Conversation

@BocamoCM
Copy link

@BocamoCM BocamoCM commented Aug 18, 2025

Closes #594

@github-actions github-actions bot added the translation changes When something in the translation changes label Aug 18, 2025
@BocamoCM
Copy link
Author

image image image image image image image

@GameTec-live
Copy link
Owner

very cool, will take a look once home.
Why are the folders blue tho lol

@BocamoCM
Copy link
Author

very cool, will take a look once home. Why are the folders blue tho lol

what color do you want? same asthe icon? **
image
**

@BocamoCM
Copy link
Author

image

@Foxushka
Copy link
Collaborator

Just for easier review, is it 100% vibecoded or parts were manually written?

@BocamoCM
Copy link
Author

BocamoCM commented Aug 18, 2025

Just for easier review, is it 100% vibecoded or parts were manually written?

parts where manually written , can be used for have a base of a folder system, ofc can be better implemented. ify want ,close this and do this by your side.

Copy link
Collaborator

@Foxushka Foxushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made quick look, didn't tested code yet

Copy link
Collaborator

@Foxushka Foxushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. No way to edit folder color

  2. No icon consistency, cards and dictionaries use different icons

image image
  1. No icon consistency, cards use filled icon, dictionaries use outlined

  2. Cards has manage icons in header, should be moved to title, like in dictionaries

image
  1. In folder management maybe change this to X icon
image
  1. In folder management UID isn't rendered properly for LF cards
image
  1. Could be cool if you can drag and drop cards into folders, in both folder management and main menu, maybe some delay is required before moving to ignore accidental moves

  2. Strange padding, maybe it should be on one line? Or somehow show if those cards in that folder, like |_ or border, root folders and cards should have same padding

image
  1. In folder management maybe add ability to close folder

  2. I've edited card in folder and it jumped into root

  3. Write card page doesn't have folders, was clicking filter and it crashed

image

@GameTec-live
Copy link
Owner

  1. and 7.;
    MaterialUI has dedicated delete / trash icons, maybe consider them.
    While i agree that drag and drop would be awsome as hell, i wouldnt consider it essential as it may be annoying to implement. Afaik flutter has decent dnd support tho.

Another thing to consider is, that with cards the default color is set by the theme (i think, or its just orange nomatter what, idk, need to check the code), but you can change it. having a selectable color on the folders would help with visual organization, If possible, please adopt smthng similar to what the card icons are doing.

@longtrung94
Copy link

in android we cant found folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translation changes When something in the translation changes

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Folders in Slot Manager

4 participants