Skip to content

Conversation

@remkos
Copy link
Contributor

@remkos remkos commented Jan 3, 2025

Description of proposed changes

This is the squelch warnings when compiling the seis package. @seisman and @joa-quim, please take note!

I have doubts about the lines with the new line numbers 313-319. I did not change the program flow, just avoided the warning about the (second) empty if by moving the semicolon to a new line. But I really wonder if those two ifs are correct, as well as where tensor_end = true; belongs, particularly given the original indentation. Maybe some {} where missing?

Addresses #8653

Reminders

  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

@remkos remkos requested review from joa-quim and seisman January 3, 2025 14:10
@remkos remkos mentioned this pull request Jan 3, 2025
51 tasks
@remkos remkos requested a review from a team January 3, 2025 14:59
@remkos remkos added this to the 6.6.0 milestone Jan 3, 2025
@remkos remkos added the maintenance Boring but important stuff for the core devs label Jan 3, 2025
@joa-quim
Copy link
Member

joa-quim commented Jan 3, 2025

I have doubts about the lines with the new line numbers 313-319.

Yes, I was staring at them too trying to figure out the meaning (and couldn't). But this is C code that the ISF site provides, so I guess in lack of better information the best is to leave them as they are.

@remkos remkos merged commit 7764c3a into master Jan 3, 2025
15 of 18 checks passed
@remkos remkos deleted the seis_warning_fixes branch January 3, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants