grdsample: Fix the incorrect handling of -Am and -Ap #8667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
commented
Jan 4, 2025
|
|
||
| for (i = 1; i < n; i++) { | ||
| if (mode == GMT_STAIRS_Y) { /* First follow x, then y */ | ||
| if (mode == GMT_STAIRS_X) { /* First follow x, then y */ |
Member
Author
There was a problem hiding this comment.
This if-statement should check mode == GMT_STAIR_X, because at lines 455, the y values are constant and the x values are changing.
Contributor
There was a problem hiding this comment.
Yes, and with GMT_STAIRS_Y = 1, GMT_STAIRS_X = 2, that matches now all the comments.
As a matter of fact, I met this issue once, but thought I had made a user error.
Contributor
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded imagesModified images
Report last updated at commit 8a57876 |
remkos
approved these changes
Jan 4, 2025
|
|
||
| for (i = 1; i < n; i++) { | ||
| if (mode == GMT_STAIRS_Y) { /* First follow x, then y */ | ||
| if (mode == GMT_STAIRS_X) { /* First follow x, then y */ |
Contributor
There was a problem hiding this comment.
Yes, and with GMT_STAIRS_Y = 1, GMT_STAIRS_X = 2, that matches now all the comments.
As a matter of fact, I met this issue once, but thought I had made a user error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8645 (comment) for context.
This PR fixes the sample1d -Am|-Ap issue.