Fix option -B+n in psscale #8737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses one of the points raised in the Forum issue https://forum.generic-mapping-tools.org/t/colour-scheme-without-outline/5967 Now we can do `psscale -Dx6.5/1+w340p/36p+h -B+n -Ccyclic > cyclic.ps` and have no frames at all. I would like also that `-B0` did that work (a nicer syntax, IMO) and in fact, this PR also implements it but it requires that GMT is built with `-DB0_IS_NO_FRAME`. The reason for wrapping it in a `#ifdef` is that changing `-B0` to do what it originally should have been since the beginning (that is, to DO NOT PLOT ANY FRAME, ANNOTS AT ALL) is a breaking change. I would like, however, to discuss if we should do it nevertheless.
Member
Author
|
I can't find where is -B0 documented. Because if it isn't we could still make -B0 == -B+n, that is no frames at all. What -B0 currently does can also be achieved with |
Member
|
I didn't see the comment on the discussion. |
Member
Author
Only if -B0 is documented. But it would break some tests that use it (nothing serious, though). |
Member
Author
|
Ok, I'm going to merge this and leave discussion to #8740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses one of the points raised in the Forum issue https://forum.generic-mapping-tools.org/t/colour-scheme-without-outline/5967
Now we can do
psscale -Dx6.5/1+w340p/36p+h -B+n -Ccyclic > cyclic.psand have no frames at all.I would like also that
-B0did that work (a nicer syntax, IMO) and in fact, this PR also implements it but it requires that GMT is built with-DB0_IS_NO_FRAME. The reason for wrapping it in a#ifdefis that changing-B0to do what it originally should have been since the beginning (that is, to DO NOT PLOT ANY FRAME, ANNOTS AT ALL) is a breaking change. I would like, however, to discuss if we should do it nevertheless.