Fix psmeca failure when P and T axes have equal dips #8862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the psmeca module where the function failed when the P (pressure) and T (tension) axes have equal dips. The fix modifies the logic in the meca_axe2dc function to properly handle the edge case of equal dips while excluding the strike-slip fault case.
Key changes:
- Enhanced conditional logic to detect when P and T axes have equal dips (within tolerance)
- Added special handling to exclude strike-slip faults where both dips are near zero
- Added explanatory comments documenting the logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
joa-quim
approved these changes
Jan 9, 2026
Member
joa-quim
left a comment
joa-quim
left a comment
There was a problem hiding this comment.
CI continue a incomprehensible disaster. Run the tests locally and and all seem fine. Two points though:
- We use C comments, not C++ (Copilot invention)
- What about a new test for this case?
Member
|
Looks good. Could you please add a test for it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried again, however, unlike before, I was able to download the dvc files during this local test, so I used the results from the master branch for the test.
Fixes #8009