Skip to content

pygmt.grdpaste: Join two grids along their common edge#4399

Open
Chuan1937 wants to merge 25 commits intoGenericMappingTools:mainfrom
Chuan1937:grdpaste
Open

pygmt.grdpaste: Join two grids along their common edge#4399
Chuan1937 wants to merge 25 commits intoGenericMappingTools:mainfrom
Chuan1937:grdpaste

Conversation

@Chuan1937
Copy link
Member

@Chuan1937 Chuan1937 commented Feb 9, 2026

@seisman seisman added the feature Brand new feature label Feb 9, 2026
@seisman seisman added this to the 0.19.0 milestone Feb 9, 2026
Chuan1937 and others added 2 commits February 9, 2026 18:20
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman
Copy link
Member

seisman commented Feb 9, 2026

Also need to add it to doc/api/index.rst.

@Chuan1937 Chuan1937 requested a review from seisman February 10, 2026 01:21
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 10, 2026
Chuan1937 and others added 5 commits February 10, 2026 15:51
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937
Copy link
Member Author

Chuan1937 commented Feb 10, 2026

Could you also please check the min and max values in the result?
Must use temporary files for xarray.DataArray inputs because virtualfile_in returns all zeros when handling grdpaste.

@Chuan1937 Chuan1937 requested a review from seisman February 10, 2026 08:50
@seisman
Copy link
Member

seisman commented Feb 10, 2026

Could you also please check the min and max values in the result? Must use temporary files for xarray.DataArray inputs because virtualfile_in returns all zeros when handling grdpaste.

I think this points to an upstream GMT bug, which should be fixed.

@seisman seisman removed the needs review This PR has higher priority and needs review. label Feb 10, 2026
@seisman seisman marked this pull request as draft February 10, 2026 09:07
@Chuan1937 Chuan1937 marked this pull request as ready for review February 15, 2026 03:34
@Chuan1937
Copy link
Member Author

Chuan1937 commented Feb 15, 2026

Due to a bug fix in the upstream GMT GenericMappingTools/gmt#8901, I was able to run test_grdpaste successfully after recompiling GMT locally. The test failure here likely also requires the latest GMT.

@seisman

@Chuan1937 Chuan1937 self-assigned this Feb 15, 2026
@seisman
Copy link
Member

seisman commented Feb 15, 2026

Could you please mark these tests as xfail for GMT older than 6.6 and also document that this method need GMT dev version

@seisman
Copy link
Member

seisman commented Feb 15, 2026

There are 4 cases: file in file out, file in xarray out, xarray in file out, xarray in xarray out. At least the first case works with gmt 6.6, right?

@Chuan1937
Copy link
Member Author

Chuan1937 commented Feb 15, 2026

There are 4 cases: file in file out, file in xarray out, xarray in file out, xarray in xarray out. At least the first case works with gmt 6.6, right?

Yes, But test_grdpaste only include case 3, 4. Do I need to add case1,2?

@seisman
Copy link
Member

seisman commented Feb 15, 2026

There are 4 cases: file in file out, file in xarray out, xarray in file out, xarray in xarray out. At least the first case works with gmt 6.6, right?

Yes, But test_grdpaste only include case 3, 4. Do I need to add case1,2?

Yes please

Chuan1937 and others added 3 commits February 17, 2026 09:11
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@Chuan1937 Chuan1937 requested a review from seisman February 17, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Brand new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants