Merged
Conversation
missing_files' binds changed for additional _files
mandatory_files and additional_files added to array still 11 errors
adapt generate_file for additional files
… to data_id folder
BotellaA
reviewed
Aug 1, 2025
| for additional_file in missing_files.additional_files: | ||
| additional_files.append(os.path.basename(additional_file)) | ||
| mandatory_files = [ | ||
| os.path.basename(f.filename) for f in additional.mandatory_files if f.is_missing |
Member
There was a problem hiding this comment.
est-ce que cette syntax est clair pour toi ou est-ce qu'il faut réflechir a chaque fois que tu lis la ligne ?
| flask.request.json["input_geode_object"], data | ||
| flask.request.json["input_geode_object"], | ||
| data, | ||
| original_filename=flask.request.json["filename"], |
Member
There was a problem hiding this comment.
original ? pas sur que ca soit le bon nom, input/initial ?
Comment on lines
294
to
304
|
|
||
|
|
||
| # def file_exists_in_upload(filename: str) -> bool: | ||
| # """Vérifie si un fichier existe dans le dossier d'upload.""" | ||
| # file_path = upload_file_path(filename) | ||
| # return os.path.exists(file_path) | ||
|
|
||
| # def file_exists_in_data(data_id: str, filename: str) -> bool: | ||
| # """Vérifie si un fichier existe dans le dossier de données.""" | ||
| # file_path = data_file_path(data_id, filename) | ||
| # return os.path.exists(file_path) |
| object_type = geode_functions.get_object_type(geode_object) | ||
|
|
||
| additional_files_copied = [] | ||
| if original_filename: |
Member
There was a problem hiding this comment.
il a le droit d'etre optionel ?
new test.dxf generate_viewable function separeted into 2 functions
…OpenGeodeWeb-Back into feat/input_file
…OpenGeodeWeb-Back into feat/input_file
…OpenGeodeWeb-Back into feat/input_file
…OpenGeodeWeb-Back into feat/input_file
…OpenGeodeWeb-Back into feat/input_file
…OpenGeodeWeb-Back into feat/input_file
…OpenGeodeWeb-Back into feat/input_file
…b-Back into feat/input_file
BotellaA
approved these changes
Aug 4, 2025
Member
|
🎉 This PR is included in version 5.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.