Feat/color bar #296
Feat/color bar #296
Conversation
internal/stores/mesh/cells.js
Outdated
|
|
||
| function setMeshCellsCellScalarRange(id, minimum, maximum) { | ||
| return viewerStore.request( | ||
| mesh_cells_schemas.cell_scalar_range, |
There was a problem hiding this comment.
@BotellaA même question que pour le back mais pour le viewer, veut-on vraiment 2 rpc différentes ou considère-t-on qu'un attribute est constitué d'un name et d'une range ?
Si on toggle de type d'attribute affiché on va toujours vouloir changer la range en même temps, j'ai l'impression que c'est lié
Delegate colormap conversion to stores and simplify selectors to use raw API objects
| { | ||
| response_function: (response) => { | ||
| cell_attribute_names.value = response.cell_attribute_names | ||
| cell_attribute_names.value = response.attributes || [] |
There was a problem hiding this comment.
L'api ne revoie pas un tableau vide automatiquement ?
| label="Select an attribute" | ||
| density="compact" | ||
| /> | ||
| <div> |
There was a problem hiding this comment.
Pour quoi faire cette div ?
|
|
||
| const props = defineProps({ | ||
| id: { type: String, required: true }, | ||
| meshType: { type: String, default: "polygons" }, |
There was a problem hiding this comment.
Pourquoi ça par défaut ?
| const props = defineProps({ | ||
| id: { type: String, required: true }, | ||
| meshType: { type: String, default: "polygons" }, |
There was a problem hiding this comment.
Pourquoi est-ce le seul à avoir une props meshType ?
app/utils/colormap.js
Outdated
| if (min !== undefined && max !== undefined) { | ||
| x = minVal + x * range | ||
| } | ||
| points.push( |
There was a problem hiding this comment.
Pas besoin de faire de transo des points
internal/stores/mesh/index.js
Outdated
| } | ||
|
|
||
| function setVertexScalarRange(id, meshType, minimum, maximum) { | ||
| switch (meshType) { |
There was a problem hiding this comment.
Je crois qu'on avait dit que les switchs c’était pas ouf ?
internal/stores/mesh/index.js
Outdated
| } | ||
| } | ||
|
|
||
| function setElementScalarRange(id, elementType, minimum, maximum) { |
There was a problem hiding this comment.
Pourquoi mettre une fonction générique ? On sait quel est le type de l'élément ?
internal/stores/data_style_state.js
Outdated
| export const useDataStyleStateStore = defineStore("dataStyleState", () => { | ||
| const styles = reactive({}) | ||
|
|
||
| const attributeSettings = reactive({}) |
There was a problem hiding this comment.
Les attributes doivent être stockés dans styles ? pourquoi les mettre à part ?
No description provided.