Skip to content

Conversation

@MaxNumerique
Copy link
Contributor

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nettoyer du coup

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pareil

@MaxNumerique MaxNumerique requested a review from BotellaA January 30, 2026 09:08
mapper.SetScalarModeToUseCellData()
mapper.SetScalarRange(cells.GetScalars().GetRange())

def displayScalarRange(self, data_id: str, minimum: float, maximum: float) -> None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

faut-il supprimer celle la ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je pense que c'est nécessaire de le garder. J'ai ajouté également une ligne permettant d'ignorer les valeurs absolues de la LUT et qui étire toute la palette. https://vtk.org/doc/nightly/html/classvtkMapper.html#a1fe12cd422a63862237fbc49d64c7985
Quand on charge un maillage, il affichee ses attributs avec la color map par défaut de VTK (bleu-blanc-rouge). La RPC sert à modifier la plage de valeurs affichées (par exemple de [0,100] à [20,80]). Sans ca, on ne peut plus ajuster ou "zoomer" sur les valeurs des attributs natifs.
Et si dans le front on intègre un slider, on pourra utilise le min/max via displayScalarRange plutot que setupColorMap

@MaxNumerique MaxNumerique requested a review from BotellaA February 2, 2026 08:11
self.mesh_polygons_schemas_dict["name"],
self.mesh_polygons_prefix,
)
params = schemas.PolygonName.from_dict(rpc_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "PolygonName" [attr-defined]

self.mesh_polygons_schemas_dict["scalar_range"],
self.mesh_polygons_prefix,
)
params = schemas.PolygonScalarRange.from_dict(rpc_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "PolygonScalarRange"; maybe "ScalarRange"? [attr-defined]

self.mesh_polygons_schemas_dict["color_map"],
self.mesh_polygons_prefix,
)
params = schemas.PolygonColorMap.from_dict(rpc_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "PolygonColorMap" [attr-defined]

self.mesh_points_schemas_dict["name"],
self.mesh_points_prefix,
)
params = schemas.Name.from_dict(rpc_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "Name" [attr-defined]

self.mesh_edges_schemas_dict["attribute"],
self.mesh_edges_prefix,
)
params = schemas.Attribute.from_dict(rpc_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "Attribute" [attr-defined]

self.mesh_edges_schemas_dict["attribute"],
self.mesh_edges_prefix,
)
params = schemas.Attribute.from_dict(rpc_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "Attribute" [attr-defined]

@@ -94,7 +94,7 @@ def setMeshCellsVertexColorMap(self, rpc_params: RpcParams) -> None:
self.mesh_cells_prefix,
)
params = schemas.VertexColorMap.from_dict(rpc_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "VertexColorMap" [attr-defined]

@@ -104,4 +104,4 @@ def setMeshCellsCellColorMap(self, rpc_params: RpcParams) -> None:
self.mesh_cells_prefix,
)
params = schemas.CellColorMap.from_dict(rpc_params)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "CellColorMap" [attr-defined]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "VertexAttribute" [attr-defined]

params = schemas.VertexAttribute.from_dict(rpc_params)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "CellAttribute" [attr-defined]

params = schemas.CellAttribute.from_dict(rpc_params)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "VertexScalarRange" [attr-defined]

params = schemas.VertexScalarRange.from_dict(rpc_params)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "CellScalarRange" [attr-defined]

params = schemas.CellScalarRange.from_dict(rpc_params)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants