-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/color bar #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Feat/color bar #121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nettoyer du coup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pareil
…e separate scalar range RPCs.
| mapper.SetScalarModeToUseCellData() | ||
| mapper.SetScalarRange(cells.GetScalars().GetRange()) | ||
|
|
||
| def displayScalarRange(self, data_id: str, minimum: float, maximum: float) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
faut-il supprimer celle la ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je pense que c'est nécessaire de le garder. J'ai ajouté également une ligne permettant d'ignorer les valeurs absolues de la LUT et qui étire toute la palette. https://vtk.org/doc/nightly/html/classvtkMapper.html#a1fe12cd422a63862237fbc49d64c7985
Quand on charge un maillage, il affichee ses attributs avec la color map par défaut de VTK (bleu-blanc-rouge). La RPC sert à modifier la plage de valeurs affichées (par exemple de [0,100] à [20,80]). Sans ca, on ne peut plus ajuster ou "zoomer" sur les valeurs des attributs natifs.
Et si dans le front on intègre un slider, on pourra utilise le min/max via displayScalarRange plutot que setupColorMap
rescale x value
| self.mesh_polygons_schemas_dict["name"], | ||
| self.mesh_polygons_prefix, | ||
| ) | ||
| params = schemas.PolygonName.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "PolygonName" [attr-defined]
| self.mesh_polygons_schemas_dict["scalar_range"], | ||
| self.mesh_polygons_prefix, | ||
| ) | ||
| params = schemas.PolygonScalarRange.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "PolygonScalarRange"; maybe "ScalarRange"? [attr-defined]
| self.mesh_polygons_schemas_dict["color_map"], | ||
| self.mesh_polygons_prefix, | ||
| ) | ||
| params = schemas.PolygonColorMap.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "PolygonColorMap" [attr-defined]
| self.mesh_points_schemas_dict["name"], | ||
| self.mesh_points_prefix, | ||
| ) | ||
| params = schemas.Name.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "Name" [attr-defined]
| self.mesh_edges_schemas_dict["attribute"], | ||
| self.mesh_edges_prefix, | ||
| ) | ||
| params = schemas.Attribute.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "Attribute" [attr-defined]
| self.mesh_edges_schemas_dict["attribute"], | ||
| self.mesh_edges_prefix, | ||
| ) | ||
| params = schemas.Attribute.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "Attribute" [attr-defined]
| @@ -94,7 +94,7 @@ def setMeshCellsVertexColorMap(self, rpc_params: RpcParams) -> None: | |||
| self.mesh_cells_prefix, | |||
| ) | |||
| params = schemas.VertexColorMap.from_dict(rpc_params) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "VertexColorMap" [attr-defined]
| @@ -104,4 +104,4 @@ def setMeshCellsCellColorMap(self, rpc_params: RpcParams) -> None: | |||
| self.mesh_cells_prefix, | |||
| ) | |||
| params = schemas.CellColorMap.from_dict(rpc_params) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "CellColorMap" [attr-defined]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "VertexAttribute" [attr-defined]
| params = schemas.VertexAttribute.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "CellAttribute" [attr-defined]
| params = schemas.CellAttribute.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "VertexScalarRange" [attr-defined]
| params = schemas.VertexScalarRange.from_dict(rpc_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [mypy] reported by reviewdog 🐶
Module has no attribute "CellScalarRange" [attr-defined]
| params = schemas.CellScalarRange.from_dict(rpc_params) |
No description provided.