Conversation
|
Hi @vfisikop !
and then import dingo
..If there is not a reason I am not aware of to change the namespace all over, I would suggest to go with the above solution. |
|
I proposed that change since I think it is more clear to have a unique name everywhere (namespace, package etc). Also since there is a package named |
|
I have no strong opinion on this, I just really enjoyed the |
|
@TolisChal what is your opinion? |
|
I agree to keep the dingo name everywhere instead of PyPi package where the name would be I updated my PR. |
| sparseqr = "^1.2.1" | ||
| simplejson = "^3.17.2" | ||
| Cython = "^0.29.22" | ||
| numpy = "^1.20.1" |
There was a problem hiding this comment.
funny we had numpy twice.
|
|
||
| # information about the dingo library | ||
| version = "0.1.0" | ||
| version = "0.1.5" |
There was a problem hiding this comment.
I have never tried this before, but since the PyPi is the main goal of this PR, do you think we should consider setting something like this ?
There was a problem hiding this comment.
That could be an option, we should definitely discuss it.
There was a problem hiding this comment.
However, the process of publishing with poetry is quite straightforward. For example, I am following this guide https://www.digitalocean.com/community/tutorials/how-to-publish-python-packages-to-pypi-using-poetry-on-ubuntu-22-04
So, I would not add more complication at this stage.
You mean for this PR or in general? We can discuss the auto-formatting. I have experience with that in Python but I have mixed filings in general. @TolisChal had used |
|
In order to make PyPi work in my case, I had to do something like:
|
This is needed for creating a pip package (since the
dingoname is already used).