Fix TLS v1.3 on modern Postfix #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanCoding
approved these changes
Sep 18, 2025
Owner
GermanCoding
left a comment
GermanCoding
left a comment
There was a problem hiding this comment.
I knew about the new postfix logging, but I tested this back when 3.9 came out, and I swear the old regex worked with it. But yeah, I just checked again and it doesn't. Maybe we broke it somewhere in between, as we were missing the test for the new logging - thanks for that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current versions of Postfix also attach details about the key-exchange, server-signature and server-digest to the header, causing the plugin to display 'unencrypted' on TLS 1.3 messages.
This PR adds an additional test case for those messages and fixes the regex to work for Stalwart, Postfix TLS 1.2, Postfix TLS 1.3 (old test) and this new Postfix TLS 1.3 syntax.