Attachment Picker structural redesign #6112
Draft
+2,686
−2,038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SDK Size Comparison 📏
|
- Remove the overlay and dialog-like behavior from the `AttachmentsPicker` composable, making it a regular surface. - Update `AttachmentsPicker` to use `FilledIconToggleButton` for tab selection. - Set the `containerColor` on the `MessagesScreen` Scaffold to use the theme's app background.
This commit introduces a new `AttachmentTypePicker` composable. This new component acts as a tab selector for different attachment types like media, files, camera, and polls. Specific changes include: * Introducing the `AttachmentTypePicker` composable. * Adding new icons for each attachment type (media, files, camera, polls). * Adding new string resources for the attachment type labels. * Introducing a new `backgroundCoreSelected` color to `StreamColors` for the selected tab state. * Replacing `AttachmentPickerOptions` with the new `AttachmentTypePicker`. * Updating tests to cover the new `AttachmentTypePicker`.
…tsPickerMode is now passed from the view model
… internal state is now handled within the AttachmentsPickerViewModel when the picker is hidden, removing the need for an explicit `dismissAttachments()` call at the UI layer.
This change refactors the "Create Poll" functionality to be presented within a full-screen dialog instead of navigating to a separate screen. Key changes: - Introduced a new `FullscreenDialog` composable. - The `AttachmentPollPicker` now triggers this dialog to show the `CreatePollScreen`. - Added a new `AttachmentPickerCreatePoll` action to handle opening the dialog. - Updated theme tokens and typography with a new `bodyDefault` style.
Introduces a new "Commands" option in the attachment picker menu. This allows users to select and trigger slash commands directly from the attachment UI. Key changes: - Added a `Commands` mode to `AttachmentsPickerMode`. - Created `AttachmentCommandPicker.kt` to display the list of available commands. - Integrated the command picker into `AttachmentPickerContent` and `AttachmentsPickerMenu`. - Handled command selection logic to trigger the command via the `composerViewModel`.
…attachment list is synchronized immediately.
The attachment type picker now expands to fill the maximum available width.
…attachment list is synchronized immediately.
Introduces a `removeSelectedAttachment` function to the `AttachmentsPickerViewModel` to synchronize its state when an attachment is removed from the composer. This new function is called from `MessagesScreen` to ensure the selection state and order within the attachment picker are correctly updated.
andremion
force-pushed
the
redesign/AND-1030-message-composer-actions-menu-redesign
branch
from
bd448de to
1f15095
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Initial redesign of the attachment picker, which includes showing it below the message composer (not as a bottom sheet anymore) and displaying the command picker.
🛠 Implementation details
Describe the implementation
🎨 UI Changes
Add relevant screenshots
Add relevant videos
🧪 Testing
Explain how this change can be tested (or why it can't be tested)
Provide a patch below if it is necessary for testing
Provide the patch summary here
🎉 GIF
Please provide a suitable gif that describes your work on this pull request