Use component factory for Giphy attachments and update design #6128
+248
−312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SDK Size Comparison 📏
|
gpunto
changed the title
VelikovPetar
reviewed
Feb 4, 2026
| .fillMaxWidth() | ||
| .height(1.dp) | ||
| .background(color = ChatTheme.colors.borders), | ||
| ChatTheme.componentFactory.GiphyAttachmentContent( |
Contributor
There was a problem hiding this comment.
Just curious: Are we not providing the whole Giphy message as configurable via the component factory (with the Only visible to you and the buttons)?
Contributor
Author
There was a problem hiding this comment.
Hmm, good question. I didn't touch it because today we don't have it, but probably we should. WDYT?
Contributor
Author
There was a problem hiding this comment.
Actually nevermind, we have MessageGiphyContent in the factory
| ) | ||
| } | ||
|
|
||
| @Composable |
Contributor
There was a problem hiding this comment.
Can we add the missing KDocs on public API?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Continuing with the message content structural changes started in #6119 and #6124, this time for Giphy attachments. This PR updates the Giphy message design and integrates it with the component factory pattern.
🛠 Implementation details
🎨 UI Changes
🧪 Testing
Can be checked in the sample app by sending Giphy attachments.