fix rscript not found issue, gzip removed for speed#11
Open
alexyfyf wants to merge 1 commit intoGoekeLab:mainfrom
Open
fix rscript not found issue, gzip removed for speed#11alexyfyf wants to merge 1 commit intoGoekeLab:mainfrom
alexyfyf wants to merge 1 commit intoGoekeLab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andre and Minghao,
I have tried to use your pipeline to run bambu_clump, I have noticed a few issues.
1, the flexiplex step took very long to finish, I checked the log and found most time was spent in gzip which is not paralleled. I suggest to remove this step since minimap2 can take fastq as input in the later process. This will speed up the flexiplex process. To give you an idea, your 240million PacBio data took 1.5-2hrs in barcode detention with flexiplex, 3 hours umi demux with flexiplex, but 15 hours in gzip, which also resulting minimap2 later run 18hours. (all with 48 cores).
In addition, the barcode detection can be run on a subsampled subset if the input file is too big, which could also speed up the flexiplex process.
2, Rscript in your
projectDiris not found in your docker image, so when you callsource(script), it cannot find the script. I tried to adjust the mounting path, but seems still not working. This could be related to different setting of nextflow cache and working directory path on our HPC.So, I have forked your repo and made a few edits to make the entire pipeline work at least on our HPC.
I have created a pull request for this.
Cheers,
Alex