Skip to content

Conversation

@cying111
Copy link
Collaborator

@cying111 cying111 commented Jan 7, 2026

This PR is created to resolve the issues related to xgboost updates, specifically:

  • update all label features to be type logical in both testSpliceSite and getTranscriptScores function
  • update pre-saved models for both splicing junction prediction and defaultModels for read class scoring
  • update test code for xgboost as well as saved outputs relevant to xgboost testing

@cying111 cying111 requested a review from Copilot January 8, 2026 01:13
@cying111 cying111 requested review from SuiYue-2308 and jonathangoeke and removed request for Copilot January 8, 2026 01:13
Copy link
Collaborator

@SuiYue-2308 SuiYue-2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I’ve reviewed the code changes and everything looks good. I also tested it on a real dataset (dRNA), and it ran smoothly.

Update about xgboost pull request.

  • In annotation-free mode, the se objects produced by the two branches are identical.
  • Annotation-provided mode, the se objects are no longer identical.
    (1) NDR score is similar (0.04597701 v.s. 0.04595099)
    (2) Novel transcripts: The number of novel transcripts differs between XGBoost versions (340 with XGBoost 1.7.11.1 vs. 345 with XGBoost 3.1.3.1). Among these, 279 transcripts have identical rowRanges.
    (3) Expression levels: Transcript-level read counts are largely similar; the differences might from XGBoost update.

Copy link
Member

@jonathangoeke jonathangoeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add release note. Thanks!

@cying111 cying111 merged commit b61c9a3 into devel_pre Jan 14, 2026
@cying111 cying111 deleted the xgboost_bug_fix branch January 15, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants