-
Notifications
You must be signed in to change notification settings - Fork 26
Xgboost bug fix #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xgboost bug fix #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I’ve reviewed the code changes and everything looks good. I also tested it on a real dataset (dRNA), and it ran smoothly.
Update about xgboost pull request.
- In annotation-free mode, the se objects produced by the two branches are identical.
- Annotation-provided mode, the se objects are no longer identical.
(1) NDR score is similar (0.04597701 v.s. 0.04595099)
(2) Novel transcripts: The number of novel transcripts differs between XGBoost versions (340 with XGBoost 1.7.11.1 vs. 345 with XGBoost 3.1.3.1). Among these, 279 transcripts have identical rowRanges.
(3) Expression levels: Transcript-level read counts are largely similar; the differences might from XGBoost update.
jonathangoeke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add release note. Thanks!
This PR is created to resolve the issues related to xgboost updates, specifically: