fix: Correctly set the credentials token source and the WithIAMAuthN opt #2544
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: needs unit tests Fixes GoogleCloudPlatform#2542
mruoss
changed the title
mruoss
force-pushed
the
gh-2542-impersonate-flag-fix
branch
from
025cdd1 to
01a6f0e
Compare
mruoss
force-pushed
the
gh-2542-impersonate-flag-fix
branch
from
01a6f0e to
4fc6bc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2542
Replaces #2543
Additional to #2543: Test (fails without the code change) and setting options was missing.