Skip to content

fix(vision): Improve logo detection #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iennae merged 1 commit into from
Jan 7, 2026
Merged

fix(vision): Improve logo detection #4209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 60 additions & 9 deletions vision/detect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ async function detectTextGCS(bucketName, fileName) {
async function detectLogos(fileName) {
// [START vision_logo_detection]
const vision = require('@google-cloud/vision');
const fs = require('fs');

// Creates a client
const client = new vision.ImageAnnotatorClient();
Expand All @@ -211,17 +212,42 @@ async function detectLogos(fileName) {
*/
// const fileName = 'Local image file, e.g. /path/to/image.png';

const imageBuffer = fs.readFileSync(fileName);
const base64Image = imageBuffer.toString('base64');

const request = {
requests: [
{
image: {
content: base64Image,
},
features: [
{
type: 'LOGO_DETECTION',
},
],
},
],
};

// Performs logo detection on the local file
const [result] = await client.logoDetection(fileName);
const logos = result.logoAnnotations;
console.log('Logos:');
logos.forEach(logo => console.log(logo));
const [response] = await client.batchAnnotateImages(request);

response.responses.forEach(res => {
if (res.logoAnnotations) {
console.log('Logos:');
res.logoAnnotations.forEach(logo => console.log(logo));
}

if (res.error) {
console.error(` - Error: ${res.error.message}`);
}
});
// [END vision_logo_detection]
}

async function detectLogosGCS(bucketName, fileName) {
// [START vision_logo_detection_gcs]
// Imports the Google Cloud client libraries
const vision = require('@google-cloud/vision');

// Creates a client
Expand All @@ -233,11 +259,36 @@ async function detectLogosGCS(bucketName, fileName) {
// const bucketName = 'Bucket where the file resides, e.g. my-bucket';
// const fileName = 'Path to file within bucket, e.g. path/to/image.png';

const request = {
requests: [
{
image: {
source: {
imageUri: `gs://${bucketName}/${fileName}`,
},
},
features: [
{
type: 'LOGO_DETECTION',
},
],
},
],
};

// Performs logo detection on the gcs file
const [result] = await client.logoDetection(`gs://${bucketName}/${fileName}`);
const logos = result.logoAnnotations;
console.log('Logos:');
logos.forEach(logo => console.log(logo));
const [response] = await client.batchAnnotateImages(request);

response.responses.forEach(res => {
if (res.logoAnnotations) {
console.log('Logos:');
res.logoAnnotations.forEach(logo => console.log(logo));
}

if (res.error) {
console.error(` - Error: ${res.error.message}`);
}
});
// [END vision_logo_detection_gcs]
}

Expand Down
Loading