2.0 preview. Fix - dynamic markers update problems#375
Open
vanooo wants to merge 5 commits intoGoogleWebComponents:2.0-previewfrom
Open
2.0 preview. Fix - dynamic markers update problems#375vanooo wants to merge 5 commits intoGoogleWebComponents:2.0-previewfrom
vanooo wants to merge 5 commits intoGoogleWebComponents:2.0-previewfrom
Conversation
New attribute for google-map to disable zooming on mouse scroll. <google-map disable-scroll-wheel-zoom ></google-map>
disable scroll wheel zoom
In iron-selectable.html there is no such event like "items-changed" -> we need to listen to "iron-items-changed".
Fix wrong listener in update function for Markers.
We are using MutationObserver - to work it properly we need to set "characterData" to "true". (Set to true if mutations to target's data are to be observed - https://developer.mozilla.org/en/docs/Web/API/MutationObserver). + extra check whether listeners exist before clear them.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue was: wrong info window (took content from the first marker) after dynamic change of markers list.