attribute native hidden and title in Polymer 2#427
Open
kimagure44 wants to merge 1 commit intoGoogleWebComponents:masterfrom
Open
attribute native hidden and title in Polymer 2#427kimagure44 wants to merge 1 commit intoGoogleWebComponents:masterfrom
kimagure44 wants to merge 1 commit intoGoogleWebComponents:masterfrom
Conversation
kimagure44
commented
Aug 2, 2018
Solved the failure in polymer 2 with the hidden attribute.
When you use the Google Maps component in Polymer 2 the hidden attribute is not working as in Polymer 1,
it only works the first time.
It seems that with the native attributes of html 'hidden', 'title', etc ... in polymer 2 in this
component they do not react to the change.I have reviewed the 'attributeChanged' method and it
appears as deprecated and according to the official documentation they recommend using
the 'attributeChangedCallback' method, but it behaves the same with the native attributes.
I imagine that since they are native attributes they have a behavior that in polymer 1 if it worked
but in polymer 2 it does not do in binding.
Solution: The first solution was to create a property that would replace the behavior of the hidden
or the title, but the final solution is much simpler. You have to declare the native
attributes 'hidden' or 'title' as properties of the component, in this way Native attributes
work correctly
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Author
|
I signed it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.