Remove tty check from table component #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmitche
approved these changes
Dec 6, 2025
Collaborator
djmitche
left a comment
djmitche
left a comment
There was a problem hiding this comment.
Will you be able to make a corresponding change to taskwarrior?
lauft
force-pushed
the
feature/remove-tty-check
branch
from
5d227f5 to
693f33e
Compare
Check for tty should be done in the application and passed to the table. Replace tty check with explicit setting for colored output. Relates to GothenburgBitFactory/timewarrior#727 GothenburgBitFactory/timewarrior#730 Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
lauft
force-pushed
the
feature/remove-tty-check
branch
from
693f33e to
46b30b0
Compare
Member
Author
|
@djmitche I have created GothenburgBitFactory/taskwarrior#4005 for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During fix of GothenburgBitFactory/timewarrior#727, I noticed that the
Tablecomponent does its own TTY check (in line Table.cpp:103) to decide whether the output is piped and thus should not be colored.It can be overridden, but only to enforce color in otherwise uncolored output. However, it is not possible to enforce uncolored output in a TTY. There is the
:nocolorhint, but it is not passed to the table, and the override only lets one switch color on, but not explicitly off.For better handling, the check for TTY should be done in only the application and passed to the table.
Relates to GothenburgBitFactory/timewarrior#730