Skip to content

Added Ctrl modifier that filters selection to include only child nodes #3665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsjgdh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added Ctrl modifier that filters selection to include only child nodes #3665

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058e5a6
Added Ctrl modifier that filters selection to include only child nodes
jsjgdh Jan 21, 2026
9b067e2
Merge branch 'master' into selecting-child-node
jsjgdh Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1957,6 +1957,7 @@ impl<'a> MessageHandler<NodeGraphMessage, NodeGraphMessageContext<'a>> for NodeG

let shift = ipp.keyboard.get(Key::Shift as usize);
let alt = ipp.keyboard.get(Key::Alt as usize);
let control = ipp.keyboard.get(Key::Control as usize);
let Some(selected_nodes) = network_interface.selected_nodes_in_nested_network(selection_network_path) else {
log::error!("Could not get selected nodes in UpdateBoxSelection");
return;
Expand All @@ -1982,6 +1983,26 @@ impl<'a> MessageHandler<NodeGraphMessage, NodeGraphMessageContext<'a>> for NodeG
}
}
}

if control {
let layer_nodes: Vec<_> = nodes.iter().filter(|node_id| network_interface.is_layer(node_id, selection_network_path)).cloned().collect();
let mut child_nodes = HashSet::new();
for layer_id in &layer_nodes {
for child_id in network_interface.upstream_flow_back_from_nodes(vec![*layer_id], selection_network_path, FlowType::LayerChildrenUpstreamFlow) {
if nodes.contains(&child_id) && child_id != *layer_id {
child_nodes.insert(child_id);
}
}
}
nodes = if alt {
previous_selection.difference(&child_nodes).cloned().collect()
} else if shift {
previous_selection.union(&child_nodes).cloned().collect()
} else {
child_nodes
};
}

if nodes != previous_selection {
responses.add(NodeGraphMessage::SelectedNodesSet {
nodes: nodes.into_iter().collect::<Vec<_>>(),
Expand Down Expand Up @@ -2769,6 +2790,7 @@ impl NodeGraphMessageHandler {
HintInfo::mouse(MouseMotion::LmbDrag, "Select Area"),
HintInfo::keys([Key::Shift], "Extend").prepend_plus(),
HintInfo::keys([Key::Alt], "Subtract").prepend_plus(),
HintInfo::keys([Key::Control], "Children Only").prepend_plus(),
]),
]);
if self.has_selection {
Expand Down
Loading