Use correct clock upstream #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> (cherry picked from commit e319448)
* testing with ubuntu ntp server * message makes a little more sense with abs * bigger offsets allowed * organizing imports with isort profile `google` --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> (cherry picked from commit c4f7231)
* NTP monitor improvements * commit to run tests again * bring back double callback * remove whiteline --------- Co-authored-by: Angsa Deployment Team <team@angsa-robotics.com> (cherry picked from commit 7efb71a) Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>
* refactor(ram_monitor): ros2 port * Update diagnostic_common_diagnostics/diagnostic_common_diagnostics/ram_monitor.py * Apply suggestions from code review * Update diagnostic_common_diagnostics/README.md * fstrings * python3 --------- Co-authored-by: Christian Henkel <6976069+ct2034@users.noreply.github.com>
* Fix usage of rclcpp::ok with a non-default context The current implementation calls `rclcpp::ok` without any arguments, which amounts to verifying that the global default context is valid. In the case where a node is added to a custom context, and the global context is not used, `rclcpp::ok` without any arguments will always return `false` since the global context has never been initialized. To fix it, pass to rclcpp the context that's available via the node's base interface. * Add a test for custom context
…egradation (ros#324) (ros#355) * Aggregator: publish diagnostics_toplevel_state immediately on every degradation * Update docs * Re-use the publishData function such that also the actual diagnostics are available * Expand test with more degradation cases (cherry picked from commit dbaec04) Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
* Add add_analyzer functionality * Add copyright notice and license, remove unused includes, re-order includes correctly * Increase clarity of prefix_ by renaming it to analyzers_ns_ * Add add_analyzer functionality * Fix bug where base_path is not reset correctly * Make the parameter forwarding condition more generic, fix the default service namespace from diagnostics_agg to analyzers * Add an add_analyzer example to the diagnostic_aggregator * Update the relevant READMEs * Fix linter errors * Add test for add_analyzer at runtime, remove unnecessary ros info logger, remove unnecessary hardcoded namespace from yaml files * Remove the now redundant analyzers_ns_ * Change the copyright of add_analyzer, forgot to update it to Nobleo after copying the notice (cherry picked from commit 5e1415c) Co-authored-by: MartinCornelis2 <51268547+MartinCornelis2@users.noreply.github.com>
* adopting changes similar to jazzy Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * Can we skip this workaround? Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
thanks to https://github.com/reinzor Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> (cherry picked from commit e67a69c)
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
* Port hd_monitor to ROS2 (ros#334) * Port hd_monitor.py * Adapt documentation and CMakeList to new hd_monitor.py * Fix execution flag of hd_monitor * Add launch test for hd_monitor * Implement low and crit parameters in hd_monitor * Improve hd_monitor code quality (cherry picked from commit 05a9645) * fixing pep257 problems introduced by ros#334 (ros#384) Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Antoine Lima <7421319+limaanto@users.noreply.github.com>
* skipping flaky ntp test Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * Also skipping tests in diagnostic_aggregator Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * also the test_critical_pub skipped Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * oh no .. Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> (cherry picked from commit beb9935) # Conflicts: # diagnostic_updater/CMakeLists.txt
* Hostnames are properly cleaned to only contain alphanumeric characters or underscore. * changed string sanitation (symbols must be ascii and alphanumeric) * Changes now conforming to linting rules * flake8 fixes Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Christian Henkel <christian.henkel2@de.bosch.com> (cherry picked from commit cca0f14) Co-authored-by: sjusner <simon.jusner@knapp.com>
* Support custom `rclcpp::NodeOptions` This eases static composition of multiple ROS 2 nodes * Fix * Update aggregator.hpp (cherry picked from commit 53555cf) Co-authored-by: Patrick Roncagliolo <ronca.pat@gmail.com>
* Checking licenses in ci Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * Header fix Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * New tools version Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * Header fix Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> * Header fix Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> (cherry picked from commit 484cca0)
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
* Grafana Integration (ros#425) * First working version of remote_logging * Added more error handling, and skipping values when new line is present in stat * Changed default telegraf url to reflect the change to influxdb_v2_listener * Made node composable and changed name to influx to better reflect use cases * Added README * Escaping string values fixed * Build fix on farm * Adde curl dependency * Removed Curl Dependency as build does not work on farm * Curl Dependency * Added unit tests for influx_line_protocol * Only depend on gtest when testing * Apply suggestions from code review * Added diagnostic_remote_logging * Added BSD clause and added untested function * Apply suggestions from code review * Implemented linter feedback * removed build warning * Fixed linting erorrs that were fixed by auto formatting --------- Co-authored-by: Daan Wijffels <dwijffels@lely.com> Co-authored-by: Thiever Base <thiever@lely.com> Co-authored-by: Christian Henkel <6976069+ct2034@users.noreply.github.com> (cherry picked from commit 6e54e7f) * formatting fixes Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Daan Wijffels <daanwijffels@gmail.com>
* Use percentage for HD usage instead of ratio * Update readme * Use global vars as default values * Fix test * Add ParameterDescriptor --------- Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com> Co-authored-by: Christian Henkel <christian.henkel2@de.bosch.com> (cherry picked from commit 207f0c0) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.