Skip to content

Conversation

@jurrejelle
Copy link
Contributor

What

Re-adds the missing fluid builder

Implementation Details

Materials with a builder NEED to be registered to the gtceu: namespace, or they will get a

    Exception message: java.lang.IllegalStateException: Some intrusive holders were not registered: [Reference{null=[unregistered]}] 
    
    ```
    StartupEvents.registry('gtceu:material', event => {
event.create('gtceu:soul_stained_alumina')
    .color(0xdb3dff).secondaryColor(0xe683fc)
    .ingot()
// THIS material is broken, in the context the fluidbuilder is now dead...
event.create('gtceu:source_oils')
    .liquid(new GTFluidBuilder().state(GTFluidState.LIQUID).customStill())
    .color(0xe642f5)

})

@jurrejelle jurrejelle requested a review from a team as a code owner December 25, 2025 19:58
@jurrejelle jurrejelle added 1.21 ignore changelog PR should not be added to the changelog. type: bugfix General bug fixes Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Dec 25, 2025
@github-actions github-actions bot added the Tests: Passed Game Tests have passed on this PR label Dec 25, 2025
@jurrejelle jurrejelle changed the title Jj/1.21/re add fl1uidbuilder binding Add fluidbuilder binding Dec 25, 2025
Copy link
Contributor

@Reabstraction Reabstraction left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Reabstraction Reabstraction merged commit 5989e31 into 1.21 Jan 2, 2026
6 checks passed
@Reabstraction Reabstraction deleted the jj/1.21/re-add-fluidbuilder-binding branch January 2, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.21 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: bugfix General bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants