Port Quantum Storage to MUI2 #2554

ghzdude · 2024-07-30T21:19:03Z

What

Ports Quantum chests and tanks to MUI2

Implementation Details

quantum/creative tanks/chest now use mui2

Outcome

another step on the road to MUI2

port some overlay textures

start creative quantum ui

move button row into GTGuis.java delete unused methods

fix locking for qtank

creative tank and chest done

:clueless: spotless

ALongStringOfNumbers

It feels kinda weird to have Item/Fluid Amount and the very top, and then the count at the very bottom. When there is nothing in the chest/tank there is just a big space between them. It might be best to make this into 1 line at the very top, and then display the item/fluid name below

The items displayed in the Quantum Chest don't seem to rotate any more

When taking all fluids from a locked quantum tank, the fluid name is no longer displayed in the GUI, even though the locked fluid remains in the slot in the display.

Did Quantum Storages display in the GUI if they were connected to a quantum network or not before? I am not seeing that now.

In the Creative Chest, I clicked in a stack of items, which did not populate the slot on the first time, only when I clicked again. This is only on first place of the creative chest

src/main/java/gregtech/client/utils/RenderUtil.java

src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumStorage.java

src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityCreativeChest.java

src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumStorage.java

add methods to disable automatic io in update

fix issue with fluid hatch not saving locked fluid simplify and sync toggle lock fluid simplify syncing locked fluid fixed missing fluid name when locked without fluid for qtanks

don't draw fluid slot background

new constants add todo

ghzdude · 2025-10-22T10:25:03Z

The items displayed in the Quantum Chest don't seem to rotate any more

they rotate for me, just very slowly

In the Creative Chest, I clicked in a stack of items, which did not populate the slot on the first time, only when I clicked again. This is only on first place of the creative chest

this should be fixed now, along with the other notes

use network util method for item stack to buffer

ALongStringOfNumbers

For some reason, middle clicking in creative copies the contents of the quantum tank to NBT when the item is placed in the players inventory (This is intended), but it does not work with the quantum chest.

src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityQuantumChest.java

ALongStringOfNumbers · 2025-10-25T03:34:54Z

src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityCreativeChest.java

+        return this.creativeHandler;
+    }
+
+    protected class ModifiableHandler extends QuantumChestItemHandler implements IItemHandlerModifiable {


Why is this even needed?

I need a handler to use for the item slot that is able to insert/extract like a normal handler but with simplified logic
I can't use the creative handler because it doesn't allow inserting stacks
and i can't use the regular quantum item handler because the super class can't "store" items (maxStoredItems = 0)
the old ui just set the stack directly, but that's no longer the case with mui2 as it attempts to insert the item
mui2 rc6 split the phantom item slot into it's own class, instead of being just a different synchandler

ALongStringOfNumbers · 2025-10-25T03:35:46Z

src/main/java/gregtech/common/metatileentities/storage/MetaTileEntityCreativeChest.java

+        @Override
+        public void setStackInSlot(int slot, ItemStack stack) {
+            virtualItemStack = GTUtility.copy(1, stack);
+            itemsStoredInside = stack.isEmpty() ? 0 : 1;


I don't know if the creative chest would even care about these, since there can only be 1 item in the slot, and it is never storing anything virtualized.

I have to update this since it's what is displayed in the item slot

ghzdude · 2025-10-25T05:03:08Z

Quantum Tanks writing to NBT with just a middle click is from #2169

However using ctrl-click (vanilla's way of copying TE's nbt to the pick item) is from #2428 and supports anything with the write/read to nbt methods

i could add support to chests like in 2169, but i feel it'd be redundant

edit: moving the getPickItem() method from the quantum tank up into the abstract quantum storage class causes issues with the quantum chest. i don't know why

ghzdude added the type: refactor Suggestion to refactor a section of code label Jul 30, 2024

ghzdude force-pushed the gh-port-qstorage-mui2 branch from f7f2760 to 9df4c9c Compare October 26, 2024 18:39

ghzdude force-pushed the gh-port-qstorage-mui2 branch from e59faf0 to e598eea Compare December 28, 2024 02:32

ghzdude force-pushed the gh-port-qstorage-mui2 branch from 231aeeb to fc626a3 Compare January 5, 2025 23:53

ghzdude marked this pull request as ready for review January 6, 2025 00:13

ghzdude requested a review from a team as a code owner January 6, 2025 00:13

ghzdude force-pushed the gh-port-qstorage-mui2 branch from 3faf81d to 978f1eb Compare January 6, 2025 03:37

ghzdude force-pushed the gh-port-qstorage-mui2 branch from 5630c26 to 1fda908 Compare June 23, 2025 02:28

ghzdude added 22 commits October 18, 2025 02:47

port chest to mui2

53d7793

remove old ui

136515e

more work on ui

aea6c3d

begin port of quantum tank

176d651

port some overlay textures

small fixes

79f8901

more ui things

872ad6b

more ui work

406b529

start creative quantum ui

add rendering widgets

43b8ffc

remove commented code

f106b8a

move button row into GTGuis.java delete unused methods

minor fixes + spotless

9e5bd31

fix rebase

b38ce39

format numbers better

61a8518

The Great Code Migration of 2024

1bc3080

add locking to qchest

3c4ee3a

fix locking for qtank

start work on qchest item renderer

1affdba

work on qchest ui a bit

7d6e829

introduce mapped synchandler

dd95785

fix display name

11c8129

initial work on creative chest

80f0141

spotless

6744c57

creative chest mostly done

d1d6596

port creative tank

785f20e

creative tank and chest done

ghzdude added 3 commits October 20, 2025 20:53

delete old ui code

7a4783c

add inventory back to creative ui

5a53786

:clueless: spotless

override slot limit

5dcaf00

ALongStringOfNumbers reviewed Oct 22, 2025

View reviewed changes

ghzdude added 11 commits October 21, 2025 22:00

move count to top

7ba840a

sync modifiable handler

2b79d45

add methods to disable automatic io in update

sync modifiable handler

2e3efdc

add methods to disable automatic io in update

fix issue with deserializing from legacy nbt

745e409

fix issue with deserializing from legacy nbt

f083b55

fix issue with fluid hatch not saving locked fluid simplify and sync toggle lock fluid simplify syncing locked fluid fixed missing fluid name when locked without fluid for qtanks

spotless

f2aa8f7

address todo

5a540d9

add back and fix connection icon

ac3f2e8

don't draw fluid slot background

delete deprecated code

880e6ff

fix missing button lang + new lang

0238398

new constants add todo

make activity text white and simplify

55b7b75

ghzdude added 4 commits October 22, 2025 10:08

write custom data for setLocked

d41b131

use network util method for item stack to buffer

spotless

745147c

use total world time

6776902

add method for scaling the item stack

678d549

ALongStringOfNumbers reviewed Oct 25, 2025

View reviewed changes

ghzdude added 3 commits October 24, 2025 22:49

redundant copy call

23b0304

remove redundant annotation

2deee93

add todo

cd76a08

ALongStringOfNumbers approved these changes Oct 26, 2025

View reviewed changes

add todo and small fixes

7fd1fde

ALongStringOfNumbers approved these changes Oct 27, 2025

View reviewed changes

ghzdude merged commit c622751 into GregTechCEu:master Oct 27, 2025
3 checks passed

github-project-automation bot moved this from Medium to Done in MUI2 Port Oct 27, 2025

Port Quantum Storage to MUI2 #2554

Port Quantum Storage to MUI2 #2554

Uh oh!

Conversation

ghzdude commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Implementation Details

Outcome

Uh oh!

ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghzdude commented Oct 22, 2025

Uh oh!

ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ALongStringOfNumbers Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

ghzdude Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

ALongStringOfNumbers Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

ghzdude Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

ghzdude commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ghzdude commented Jul 30, 2024 •

edited

Loading

ghzdude commented Oct 25, 2025 •

edited

Loading