Port Covers to Mui2 Part 2 #2700

ghzdude · 2025-01-18T05:45:21Z

What

Ports the rest of the covers to MUI2

Implementation Details

ALL covers now use MUI2

Outcome

Covers use MUI2, and old ui code will be removed

ALongStringOfNumbers

The tooltip of the continuous/latched mode in the Advanced Fluid Detector needs a new line, it is much too long.

Similar to a previous issue brought up, configuring the filter and then removing it will apply its configuration status to any new filter put in the Advanced Fluid Detector Cover.

Some how I was able to have filter configuration not saved when I exited the GUI of the Advanced Fluid Detection cover. This only happened once and I could not repeat it.

This error is back:
[20:43:41] [Client thread/INFO] [modularui]: unit WIDTH of widget Column was already used and will be overwritten with unit RIGHT
So maybe we need more debug names

Same filter issues with item filters in the Advanced Item detector. Putting in a smart filter, removing it and putting in an oredict filter, and then opening the filter UI still opens the smart filter.

Just a little weird math probably, when placing an advanced energy detection cover on a creative emitter, the default value for max is 488%

The Ender Link Cover does not work with the Creative Tank in my testing.

src/main/java/gregtech/common/covers/detector/CoverDetectorBase.java

src/main/java/gregtech/common/covers/detector/CoverDetectorFluidAdvanced.java

ALongStringOfNumbers · 2025-11-17T04:27:25Z

src/main/java/gregtech/common/mui/widget/GTTextFieldWidget.java

+    public @NotNull RichTooltip tooltip() {
+        tooltipOverride = true;
+        return super.tooltip();
+    }


Why do we need this special method with a tooltip override? As far as I can see, this special method isn't even used at all. Also, doesn't calling the regular tooltip builder entry just add things to the tooltip already?

it's used in onInit() to add a tooltip if it isn't specified by the user, based off of mui2's TextFieldWidget:

if (!hasTooltip() && !tooltipOverride) { tooltipBuilder(tooltip -> tooltip.addLine(IKey.str(getText()))); tooltipOverride = false; }

src/main/java/gregtech/common/mui/widget/GTTextFieldWidget.java

ALongStringOfNumbers · 2025-11-17T04:33:33Z

src/main/java/gregtech/common/mui/widget/GTTextFieldWidget.java

+import java.util.function.Supplier;
+import java.util.regex.Pattern;
+
+public class GTTextFieldWidget extends BaseTextFieldWidget<GTTextFieldWidget> {


A decent amount of this class is unused. Do we need to keep any of it?

the methods are there to match mui2's TextFieldWidget. I could extend TextFieldWidget and remove the redundant methods, but then builder calls become more complicated due to methods returning TextFieldWidget instead of GTTextFieldWidget

src/main/java/gregtech/common/mui/widget/GTTextFieldWidget.java

src/main/java/gregtech/common/covers/ender/CoverAbstractEnderLink.java

ghzdude · 2025-11-17T08:49:39Z

Similar to a previous issue brought up, configuring the filter and then removing it will apply its configuration status to any new filter put in the Advanced Fluid Detector Cover.

Same filter issues with item filters in the Advanced Item detector. Putting in a smart filter, removing it and putting in an oredict filter, and then opening the filter UI still opens the smart filter.

both of these are caused by the same problem; synced panel handlers only open their panel once. any further attempts to open them will just reopen the cached panel. deleting the cached panel is not an option because SimpleItemFilter uses phantom item slots, which throws an exception. I can't use a client only panel handler unless i replace the phantom item slots with something else. I could use a different mapkey

Zorbatron

~~I see a few methods in covers to build repetitive widgets, and they have GuiData instead of PosGuiData.~~

src/main/java/gregtech/api/cover/CoverUIFactory.java

src/main/java/gregtech/api/cover/CoverWithUI.java

src/main/java/gregtech/common/covers/CoverDigitalInterface.java

src/main/java/gregtech/common/covers/detector/CoverDetectorEnergyAdvanced.java

Zorbatron · 2025-11-29T21:20:34Z

src/main/java/gregtech/common/covers/detector/CoverDetectorEnergyAdvanced.java

What do you think about adding a progress bar at the top that shows the % fullness of the energy container the cover is attached to, and two markers where the low/high positions are?

i did have ideas like that for a while, something like create. it's best in a future pr though

src/main/java/gregtech/common/covers/detector/CoverDetectorFluidAdvanced.java

src/main/java/gregtech/common/covers/detector/CoverDetectorItemAdvanced.java

Zorbatron · 2025-11-29T21:24:20Z

src/main/java/gregtech/common/covers/detector/CoverDetectorFluidAdvanced.java

Same thing about the filled % bar as the advanced energy detector for the advanced fluid detector. It could also be done to the advanced item detector.

src/main/java/gregtech/common/covers/filter/BaseFilterContainer.java

ghzdude · 2025-11-30T05:38:53Z

I see a few methods in covers to build repetitive widgets,

what methods are you talking about exactly?

and they have GuiData instead of PosGuiData.

I use GuiData in case we want to build the widgets in a different context, see #2658

Zorbatron · 2025-11-30T05:48:16Z

what methods are you talking about exactly?

Methods like createWidgets(GuiData data, PanelSyncManager syncManager) { ... }, but I didn't know about #2658, so you can ignore that comment.

remove old ui code

improve advanced energy create GTTextFieldWidget for postfix

improve cursor positioning slightly

create common ui method in detector base

delete old ui code simplify setters

move parse

add postfix for conveyor and pump

fix CoverItemFilter filtermode syncing

use slotValue directly as value

ALongStringOfNumbers

You might also want to make the item/fluid detectors not able to attach to their respective creative sources, to mimic the energy cover.

When clicking on a slot in a fluid filter with a filled bucket, if the slot is already configured to a different fluid, the first click with the bucket will instead remove the configured fluid. You then have to click again to set the fluid in the slot to the one in the bucket. This should be condensed to one operation. If you are clicking on a configured fluid slot with a bucket that contains a different fluid, that fluid slot should just be set to the fluid in the bucket.

Testing this in the Advanced Fluid Detector cover. If you have a filter open, click on an item to open JEI for an item, close JEI, then you can no longer close the filter with the gear button in the main GUI, you have to use the x in the filter GUI. When the filter is in this state, I also cannot configure it using fluids from the inventory, only with JEI drag ghosts. However, after closing and reopening the filter, none of these ghost drags made when the filter was in this state are saved. Also you can't click to remove configured fluids.

In the Advanced Energy Detector cover, switching from the default discrete mode to percentage mode and then back sets the min EU value to -1. This was on the UHV 8x Battery Buffer. We should probably validate that the EU value in the text field cannot be negative.

Just noticed that the Quantum Network "Not Connected" TOP infor displays when looking at covers on the quantum tank/chest. That can be fixed in a different PR though.

When holding a stack of filters, right clicking a filter slot in a GUI to deposit 1 filter sets the NBT on the entire stack. instead of just the one that went in the slot. Not sure if anything can be done about this one.

src/main/java/gregtech/common/covers/detector/CoverDetectorEnergyAdvanced.java

ALongStringOfNumbers · 2025-12-01T21:34:14Z

src/main/java/gregtech/api/cover/CoverWithUI.java

+                        .overlay(new DynamicDrawable(() -> itemDrawable.setItem(stack.get())))
+                        .size(16)
+                        .marginRight(4))
+                .child(IKey.dynamic(() -> stack.get().getDisplayName())


Does the name need to be dynamic? The only case I can think of for this is changing langs, but you have to close the UI to do that so the UI would get rebuilt with the correct lang even if it was not dynamic right?

this was part of my attempts to fix the filter popup panel before settling with the current solution

since the panel is only built once, it needs to update based on what's in the filter slot, therefore it needs a supplier

i could revert this change, though i'd probably add it back later in a different pr

src/main/java/gregtech/common/covers/detector/CoverDetectorFluidAdvanced.java

src/main/java/gregtech/common/covers/filter/BaseFilter.java

add notes

move locking call into sync handlers' handle click method on server

prevent redundant sets

ghzdude · 2025-12-02T06:18:59Z

Testing this in the Advanced Fluid Detector cover. If you have a filter open, click on an item to open JEI for an item, close JEI, then you can no longer close the filter with the gear button in the main GUI, you have to use the x in the filter GUI. When the filter is in this state, I also cannot configure it using fluids from the inventory, only with JEI drag ghosts. However, after closing and reopening the filter, none of these ghost drags made when the filter was in this state are saved. Also you can't click to remove configured fluids.

Looking into this, this happens because the panel handler on the client thinks the panel isn't opened. However, trying to open the panel again never sets open to true, so it can't close the panel. also in this state, the popup panel is essentially nonfunctional as it cannot receive packet updates on the server (it no longer exists in ModularSyncManager). the x button works because it calls closePanel directly.

in short, mui2 desync issue

When holding a stack of filters, right clicking a filter slot in a GUI to deposit 1 filter sets the NBT on the entire stack. instead of just the one that went in the slot. Not sure if anything can be done about this one.

can you elaborate on this? i don't know exactly what you're trying to do

implement tank interface instead of extending add todo

src/main/java/gregtech/api/util/virtualregistry/VirtualEnderRegistry.java

Zorbatron · 2025-12-08T21:05:57Z

src/main/java/gregtech/common/covers/detector/CoverDetectorEnergy.java


    @Override
    public boolean canAttach(@NotNull CoverableView coverable, @NotNull EnumFacing side) {
-        return coverable.getCapability(GregtechCapabilities.CAPABILITY_ENERGY_CONTAINER, null) != null ||


Can the below TODO be done now? ("check this", plz write descriptive todos smh (not that you wrote that one ghz))

iirc, that todo was added by maya, idk what she means by it

src/main/java/gregtech/common/covers/detector/CoverDetectorEnergyAdvanced.java

src/main/java/gregtech/common/covers/detector/CoverDetectorEnergy.java

Zorbatron · 2025-12-08T22:14:37Z

src/main/java/gregtech/common/covers/filter/BaseFilterContainer.java

                                        panel.closePanel();
                                    }
+                                    if (client) {
+                                        manager.callSyncedAction("update_filter_panel", packetBuffer -> {});


I can't commit it since it would invalidate an approval from me, but once MUI 3.0.6 releases ~~pr 183 merges~~, the empty lambda can be removed.

ghzdude added the type: refactor Suggestion to refactor a section of code label Jan 18, 2025

ghzdude force-pushed the gh/mui2-cover-port-2 branch from cff6b7a to 33ff2bb Compare April 7, 2025 04:53

ghzdude force-pushed the gh/mui2-cover-port-2 branch from 33ff2bb to fa60a77 Compare June 13, 2025 06:27

ghzdude force-pushed the gh/mui2-cover-port-2 branch from edf6474 to 37f6808 Compare October 24, 2025 05:48

ghzdude marked this pull request as ready for review October 24, 2025 09:13

ghzdude requested a review from a team as a code owner October 24, 2025 09:13

ghzdude force-pushed the gh/mui2-cover-port-2 branch from 1fd1101 to 66a15f3 Compare October 30, 2025 01:44

ghzdude force-pushed the gh/mui2-cover-port-2 branch from dc706c2 to 3c4a0e0 Compare November 9, 2025 02:00

ghzdude force-pushed the gh/mui2-cover-port-2 branch from 3c4a0e0 to 60ade55 Compare November 17, 2025 01:19

ALongStringOfNumbers reviewed Nov 17, 2025

View reviewed changes

Zorbatron reviewed Nov 29, 2025

View reviewed changes

ghzdude added 16 commits November 29, 2025 22:58

initial work on adv energy detector

fb7b8b1

move ui method to CoverDetectorBase

f615a18

remove old ui code

port advanced item

c2bc860

improve advanced energy create GTTextFieldWidget for postfix

improve post fix rendering

b20cfc2

improve cursor positioning slightly

port advanced fluid detector

21df8e7

create common ui method in detector base

forgor filter ui

cb10a24

delete old ui code simplify setters

move filter into column

f56fc49

actually sync isInverted

68eda2e

fix compile and rebase

411052d

use default number and add setter method

2fecca8

move parse

fix textfield widgets being too tall

fe5707b

add postfix for conveyor and pump

cleanup + spotless

7d4b255

add todo

9d57591

port digital interface

e82a5eb

make slot text field editable

54df137

try improve ender fluid security

76e71ee

ghzdude added 9 commits November 29, 2025 22:58

clean up a bit

bb6a4ce

use predicate

9f39747

fix cover filters not saving and syncing allowFlow

e2e8b82

fix CoverItemFilter filtermode syncing

todo

78b200b

spotless?

2fe7a4e

properly support long counts for items and fluids

8dd76cb

replace dynamic drawables with supplier lang key

6d7cf81

use slotValue directly as value

use flow as return type

d2aa861

use throughput directly as value

93d5038

ghzdude force-pushed the gh/mui2-cover-port-2 branch from bb1658c to 93d5038 Compare November 30, 2025 06:01

spotless

8dd1b37

ALongStringOfNumbers reviewed Dec 1, 2025

View reviewed changes

ghzdude added 8 commits December 1, 2025 20:28

add CoverUIFactory back and mark for removal

bf5ede2

add notes

make item/fluid detectors unplaceable on creative chest/tank

c52eaad

drain and fill at the same time for our phantom fluid slots

099672b

move locking call into sync handlers' handle click method on server

use default values when energy capacity is zero

5a1f596

prevent redundant sets

deserialize legacy int min and max

a87782c

use passed in name for error panel

34b9bda

simplify lang key overlay

564d328

add color to the numbers

52cdca5

ghzdude added 3 commits December 2, 2025 18:34

don't handle stack tag in constructor

3f4db58

implement tank interface instead of extending add todo

really

9ae8103

not sponsored by AMD™

1caad4e

ALongStringOfNumbers approved these changes Dec 6, 2025

View reviewed changes

Zorbatron reviewed Dec 8, 2025

View reviewed changes

i accidentally the parenthesis

354908b

ALongStringOfNumbers approved these changes Dec 9, 2025

View reviewed changes

ghzdude merged commit c214f00 into master Dec 9, 2025
3 checks passed

ghzdude deleted the gh/mui2-cover-port-2 branch December 9, 2025 05:01

Port Covers to Mui2 Part 2 #2700

Port Covers to Mui2 Part 2 #2700

Uh oh!

Conversation

ghzdude commented Jan 18, 2025

What

Implementation Details

Outcome

Uh oh!

ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ghzdude commented Nov 17, 2025

Uh oh!

Zorbatron left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghzdude commented Nov 30, 2025

Uh oh!

Zorbatron commented Nov 30, 2025

Uh oh!

ALongStringOfNumbers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghzdude commented Dec 2, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Zorbatron Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Zorbatron left a comment •

edited

Loading

Zorbatron Dec 8, 2025 •

edited

Loading