Fix the JEI green overlay appearing in cheat mode on phantom slots and fix the crafting station slots not having a hover overlay #2817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix slot hover overlay in crafting station
Zorbatron
added
type: refactor
ghzdude
reviewed
Jun 29, 2025
ghzdude
reviewed
Jul 5, 2025
src/main/java/gregtech/common/mui/widget/workbench/CraftingInputSlot.java
Outdated
Show resolved
Hide resolved
Contributor
ALongStringOfNumbers
left a comment
ALongStringOfNumbers
left a comment
There was a problem hiding this comment.
The green overlay is rendered over the red missing items overlay in the crafting station, not sure what should be done in that case.
You can drag itemstacks into a fluid slot, and clicking doesn't cancel the itemstack drag like I would expect like in other cases of failed drag. There is no highlight target though, which is good.
Something might have messed up with the ghost drag cancelling, because in this PR, in the storage page of the crafting station, you can start a ghost drag even if there is no target, but not on master
src/main/java/gregtech/common/mui/widget/workbench/CraftingOutputSlot.java
Show resolved
Hide resolved
Member
Author
|
Those should all be fixed now |
ALongStringOfNumbers
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Outcome
Phantom slot overlays look nicer and have more function
Additional Information
Remind me to remove the mixins once CleanroomMC/ModularUI@5af9d83 and CleanroomMC/ModularUI#146 make it into a release that we use.