-
Notifications
You must be signed in to change notification settings - Fork 205
Fix Scroll Text Alignment Drawing Issues #2869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This makes it so the text is always aligned to the top. IMO for bottom or center alignments, it should start off in the center or bottom, and only "align" to the top once there are enough lines to fill the vertical space. |
"improve" fix to drawing scrolling text remove dirty field from ui builder
this has been implemented it's also technically possible to set the scroll based on alignment, but it makes the code more complicated and idk if it'd be desirable. |
# Conflicts: # src/main/java/gregtech/common/mui/widget/ScrollableTextWidget.java
… the max width of the entire rendering area.
What
fixes scroll text drawing incorrectly when using center or bottom alignments
noticable when not calling
alignment(), as the default alignment for richtext is center leftImplementation Details
extend text renderer to override
getStartY()also make
lastXandlastYaccessibleOutcome
scroll text widget draws properly regardless of the alignment used