[Refactor] Abstract model index getter as IItemModelDispatcher
#2882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCTian-mi
added a commit
to MCTian-mi/SussyPatches
that referenced
this pull request
Nov 10, 2025
might move this to the api package later
M-W-K
approved these changes
Nov 10, 2025
ghzdude
reviewed
Nov 12, 2025
src/main/java/gregtech/api/items/metaitem/stats/IItemModelDispatcher.java
Outdated
Show resolved
Hide resolved
ALongStringOfNumbers
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Replaced the hardcoded check in
MetaItem#getModelIndex(ItemStack)with a call to a specificIItemComponentfrom the metaValueItem, makin it easier to add items with multiple models.Implementation Details
IItemModelDispatcherwas added as a child interface ofIItemComponent, with a single methodgetModelIndex(ItemStack, int)MetaValueItemto store the model dispatcher, pretty much the same as other special `IItemComponent`sMetaItem#getModelIndex(ItemStack)now callsMetaValueItem#getItemModelDispatcher()and thenIItemModelDispatcher#getModelIndex(ItemStack, int)IElectricItemandIntCircuitIngredientare moved to new impl.