Skip to content

Conversation

@Glavo
Copy link
Member

@Glavo Glavo commented Dec 10, 2025

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request replaces the standard JavaFX CheckBox with JFXCheckBox (from JFoenix library) in TableView cells to provide a consistent Material Design appearance throughout the application. The change introduces a custom JFXCheckBoxTableCell implementation that mirrors the functionality of the standard CheckBoxTableCell while using JFXCheckBox components.

Key Changes

  • Created a new JFXCheckBoxTableCell class that implements a custom TableCell with JFXCheckBox instead of standard CheckBox
  • Updated ModUpdatesPage to use the new JFXCheckBox-based cell factory
  • Added CSS styling to disable the ripple effect on checkboxes within table views

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/JFXCheckBoxTableCell.java New custom TableCell implementation using JFXCheckBox with bidirectional property binding and disable state management
HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModUpdatesPage.java Updated to use JFXCheckBox and JFXCheckBoxTableCell instead of standard CheckBox and CheckBoxTableCell, added center alignment to the enabled column
HMCL/src/main/resources/assets/css/root.css Added CSS rule to disable ripple effect for JFXCheckBox within table views

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Glavo Glavo merged commit 8d3cb66 into HMCL-dev:main Dec 11, 2025
2 checks passed
@Glavo Glavo deleted the table-view branch December 11, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant