-
Notifications
You must be signed in to change notification settings - Fork 2
UI: Remove theme control settings. #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maphikza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal look great. but I am getting this error when I go to allowed pages on this branch, "
TypeError: Cannot read properties of undefined (reading 'requiresNpubManagement')
AllowedUsersLayout
src/components/allowed-users/layouts/AllowedUsersLayout.tsx:152
149 | }
150 |
151 | const modeConfig = MODE_CONFIGURATIONS[currentMode];
152 | const showNpubManagement = modeConfig.requiresNpubManagement ||
| ^ 153 | (localSettings.read_access.scope === 'allowed_users' || localSettings.write_access.scope === 'allowed_users');
154 | const showTiers = currentMode === 'paid' || currentMode === 'free' || currentMode === 'exclusive';
155 |
"
I my pull request this part is already handled I think we need to consolidate everything soon so that we can start testing what is outstanding.
Hm that's interesting. This really only touches a few unrelated lines and I don't get that error. Let me check it out further |
|
@Maphikza I also pulled main into my branch on my machine locally and I haven't received any TypeErrors 😕 |
|
Main is up to date it's just this branch when I was running it that gave me that error. |
Maphikza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works great mate.
Description
Fixes # (issue)
Addresses this card
generated by co-pilot
This pull request includes changes to simplify the
SettingsOverlaycomponent and remove support for preferred theme detection. The most notable updates involve commenting out unused components and code related to theme settings and night mode, as well as hardcoding the default theme to 'dark'.Simplification of
SettingsOverlaycomponent:src/components/header/components/settingsDropdown/settingsOverlay/SettingsOverlay/SettingsOverlay.tsx: Removed unused imports (NightModeSettings,ThemePicker, andAlert) and commented out the corresponding panels in the component's JSX structure. This simplifies the UI by temporarily disabling the theme picker and night mode settings. [1] [2]Removal of preferred theme detection:
src/store/slices/themeSlice.ts: Commented out thepreferredThemelogic that detects the user's system theme preference and hardcoded the default theme to 'dark'. This removes support for dynamic theme detection.Testing