Skip to content

Conversation

@AnthonyMarin
Copy link
Member

@AnthonyMarin AnthonyMarin commented Jun 26, 2025

Description

Fixes # (issue)
Addresses this card

generated by co-pilot
This pull request includes changes to simplify the SettingsOverlay component and remove support for preferred theme detection. The most notable updates involve commenting out unused components and code related to theme settings and night mode, as well as hardcoding the default theme to 'dark'.

Simplification of SettingsOverlay component:

Removal of preferred theme detection:

  • src/store/slices/themeSlice.ts: Commented out the preferredTheme logic that detects the user's system theme preference and hardcoded the default theme to 'dark'. This removes support for dynamic theme detection.

Testing

  • Verify layouts are not broken
  • Verify that light-mode is not available

@AnthonyMarin AnthonyMarin requested a review from Maphikza June 26, 2025 00:20
@AnthonyMarin AnthonyMarin self-assigned this Jun 26, 2025
@AnthonyMarin AnthonyMarin added the UI Changes to user interface. label Jun 26, 2025
@AnthonyMarin AnthonyMarin requested a review from ColbySerpa June 26, 2025 20:54
Copy link
Member

@Maphikza Maphikza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal look great. but I am getting this error when I go to allowed pages on this branch, "
TypeError: Cannot read properties of undefined (reading 'requiresNpubManagement')
AllowedUsersLayout
src/components/allowed-users/layouts/AllowedUsersLayout.tsx:152
149 | }
150 |
151 | const modeConfig = MODE_CONFIGURATIONS[currentMode];

152 | const showNpubManagement = modeConfig.requiresNpubManagement ||
| ^ 153 | (localSettings.read_access.scope === 'allowed_users' || localSettings.write_access.scope === 'allowed_users');
154 | const showTiers = currentMode === 'paid' || currentMode === 'free' || currentMode === 'exclusive';
155 |
"

I my pull request this part is already handled I think we need to consolidate everything soon so that we can start testing what is outstanding.

@AnthonyMarin
Copy link
Member Author

The removal look great. but I am getting this error when I go to allowed pages on this branch, " TypeError: Cannot read properties of undefined (reading 'requiresNpubManagement') AllowedUsersLayout src/components/allowed-users/layouts/AllowedUsersLayout.tsx:152 149 | } 150 | 151 | const modeConfig = MODE_CONFIGURATIONS[currentMode];

152 | const showNpubManagement = modeConfig.requiresNpubManagement ||
| ^ 153 | (localSettings.read_access.scope === 'allowed_users' || localSettings.write_access.scope === 'allowed_users');
154 | const showTiers = currentMode === 'paid' || currentMode === 'free' || currentMode === 'exclusive';
155 |
"

I my pull request this part is already handled I think we need to consolidate everything soon so that we can start testing what is outstanding.

Hm that's interesting. This really only touches a few unrelated lines and I don't get that error. Let me check it out further

@AnthonyMarin
Copy link
Member Author

AnthonyMarin commented Jul 3, 2025

@Maphikza I also pulled main into my branch on my machine locally and I haven't received any TypeErrors 😕

@Maphikza
Copy link
Member

Maphikza commented Jul 3, 2025

Main is up to date it's just this branch when I was running it that gave me that error.

Copy link
Member

@Maphikza Maphikza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great mate.

@Maphikza Maphikza merged commit bc7d9ae into main Jul 3, 2025
2 checks passed
@ColbySerpa ColbySerpa deleted the ui/remove-theme-settings branch September 17, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Changes to user interface.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants