Feature/ndk integration fix cleanup #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add environment-based NDK configuration with relay URLs - Implement NIP-42 authentication using NDKRelayAuthPolicies.signIn - Create hybrid profile fetching: NDK first, backend API fallback - Fix authentication issues in LoginForm and useWalletAuth - Improve display name parsing from Nostr profile data - Prevent infinite loops with better profile caching logic - Remove global Window.nostr declaration to avoid NDK conflicts
- Only use dummy data when no real subscribers exist - Keep existing real subscribers during errors - Initialize with empty array instead of dummy profiles
- Remove debug logs from TotalEarning.tsx - Remove chart data logs from TotalEarningChart.tsx - Remove API response logs from activity.api.ts - Remove extensive debug logs from useChartData.ts - Remove component logs from PaidSubscribers.tsx - Fix unused variables after log removal
f7f376a1fcd0d0e11a10ed1b6577c9
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements hybrid profile fetching with NIP-42 authentication and includes bug fixes and performance improvements:
Changes
🔐 Authentication & Profile Fetching
NDKRelayAuthPolicies.signIn🐛 Bug Fixes
⚡ Performance
useBitcoinRates🧹 Code Cleanup
Files Changed
.env.development- Add NDK relay configurationsrc/App.tsx- NDK setup and initializationsrc/components/auth/LoginForm/LoginForm.tsx- Auth improvementssrc/components/relay-dashboard/paid-subscribers/PaidSubscribers.tsx- Hybrid profile fetchingsrc/hooks/usePaidSubscribers.ts- Subscriber logic fixessrc/hooks/useBitcoinRates.ts- Caching improvementssrc/hooks/useWalletAuth.ts- Authentication fixessrc/config/config.ts- NDK configurationsrc/types/nostr.ts- Type definitionssrc/utils/utils.ts- Profile parsing utilities