Fix "Unconfirmed Transactions Cut Off" #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and avoid stacking context issues by rendering the modal at the document root
Maphikza
approved these changes
Jul 20, 2025
Member
Maphikza
left a comment
Maphikza
left a comment
There was a problem hiding this comment.
This was beautifully done and targeted Matt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with simple fix for a first PR.
The unconfirmed transaction modal was being clipped under by the left sidebar.
Due to the document nested hierarchy, simply setting a high z-index wouldn't cause the modal to appear above the rest of the content. Removing the z-index on the sidebar component would have fixed this issue, but didn't change that to reduce the possibility of introducing edge cases in other parts of the UI.
The solution used here is to use react-dom
createPortalto place the component in the root level of the document body. This correctly places the modal above the rest of the content, keeping code changes to this issue localized to the component itself.