Removed TSMP2_DIR variable from manual #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shell variable `TSMP2_DIR` is not used by `build_tsmp2.sh`. One might get the impression that it has an effect on where the building takes place, but it does not. To avoid unexpected behaviour and superfluous typing, let's remove it.
Contributor
|
Yeah, this is an artefact from the former README. I guess, it could also be removed here as currently relative paths are used afterwards. TSMP2/docs/users_guide/building_TSMP2/BuildingTSMP2wCMake.md Lines 13 to 14 in f33e097 |
s-poll
approved these changes
Sep 25, 2025
s-poll
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell variable
TSMP2_DIRis not used bybuild_tsmp2.sh. One might get the impression that it has an effect on where the building takes place, but it does not. To avoid unexpected behaviour and superfluous typing, let's remove it.