PDAF-OMI for GRACE-DA and SM-DA #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules are compiled first
independent of component model
by introducing `#ifdef CLMFIVE` constructs
jjokella
force-pushed
the
tsmp-pdaf-patched-omi
branch
from
9218e33 to
e87944c
Compare
needs to change for Intel/Gnu compilers
``` Error: Operand of .not. operator at (1) is INTEGER(4) ```
* Add Anne as author and bug fix in mod_read_obs.F90 * bug fix in mod_read_obs
``` Error: Arithmetic overflow converting REAL(16) to REAL(8) at (1). This check can be disabled with the option ‘-fno-range-check’ ```
…or multivariate DA
…m/s7yoewer/pdaf into tsmp-pdaf-patched-da-enhancements
…-patched-da-enhancements
no need to specify PDAF_SRC as input in TSMP2
goal: calling a subroutine in `-lpdaf-d` inside the code of `$(LIBMODEL)`
for -lpdaf-d and $(LIBMODEL), possibly a circular dependency?
circular dependencies not wanted this way library-subroutines can be called from model interface routines, but not the other way around (should not be needed as model interface routines should always be called by framework routines).
DA enhancements: PDAF update to 2.3, DA interval adaption, introduction of full obs-error covariance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Merge the PDAF-OMI deveopment by Yorck Ewerdwalbesloh and Anne Springer from Uni Bonn into the main code.
User
Command line switch
use_omiDeveloper
interface/framework/Makefile: Modules for each observation type and callback routines.use_omiswitchenkf_clm_mod(by observation type): TODO, link PR specializing on this modularity.tsmp-pdaf-patched-grace-da(TODO: Add PR for old-fashioned GRACE-DA)