Change default t_printensemble to disable debug output #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `t_printensemble` defaulted to `-1`, which triggered debug output at every DA time step. The debug condition checked for any negative value (`< 0`), making debug output enabled by default. This commit changes the default of `t_printensemble` to `-2` (no debug output) and updates the condition to explicitly check for -1. Debug output must now be explicitly enabled by setting `t_printensemble=-1` in `enkfpf.par`. Commit message checked after generation with [Claude Code](https://claude.com/claude-code)
jjokella
added a commit
to HPSCTerrSys/TSMP2
that referenced
this pull request
Dec 12, 2025
jjokella
added a commit
to HPSCTerrSys/TSMP2
that referenced
this pull request
Dec 17, 2025
* Change default t_printensemble to disable debug output (HPSCTerrSys/pdaf#42) * use standard isnan function from IEEE_ARITHMETIC (HPSCTerrSys/pdaf#40) * Include rounding in total_steps and tstartcycle computation (HPSCTerrSys/pdaf#39) * Documentation version handling (HPSCTerrSys/pdaf#36) * CONTRIBUTORS.txt introduced (HPSCTerrSys/pdaf#33)
jjokella
added a commit
to HPSCTerrSys/TSMP2
that referenced
this pull request
Dec 18, 2025
* Change default t_printensemble to disable debug output (HPSCTerrSys/pdaf#42) * use standard isnan function from IEEE_ARITHMETIC (HPSCTerrSys/pdaf#40) * Include rounding in total_steps and tstartcycle computation (HPSCTerrSys/pdaf#39) * Documentation version handling (HPSCTerrSys/pdaf#36) * CONTRIBUTORS.txt introduced (HPSCTerrSys/pdaf#33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
t_printensembledefaulted to-1, which triggered debug output at every DA time step. The debug condition checked for any negative value (< 0), making debug output enabled by default.This commit changes the default of
t_printensembleto-2(no debug output) and updates the condition to explicitly check for -1.Debug output must now be explicitly enabled by setting
t_printensemble=-1inenkfpf.par.Commit message checked after generation with Claude Code